question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Add missing native imports and remove "duplicates"

See original GitHub issue

Currently, ImGui.NET is very close to having full coverage of all cimgui exports for version 1.49. I did a quick diff and identified the following list of functions that are not yet imported. There are also a few functions in ImGuiNative that define helper overloads which call the actual imported function. IMO, there should only be a single import for each cimgui function, and helper overloads should go into the ImGui class, which is supposed to have the safe, friendly wrappers.

@dpethes Did you mention that you were working on TreeNode stuff? I think I am going to try to finish all of the below before I start handling the 1.50 upgrade and breaking changes.

Missing imports (Added in 93f9e60dafe179ec1c584f369db32b522ec5f674)

  • igCreateContext
  • igDestroyContext
  • igGetColorU32
  • igGetColorU32Vec
  • igGetCurrentContext
  • igGetFontTexUvWhitePixel
  • igGetKeyIndex
  • igGetTreeNodeToLabelSpacing
  • igIsItemClicked
  • igIsRootWindowOrAnyChildHovered
  • igNewLine
  • igPlotHistogram2
  • igPlotLines2
  • igProgressBar
  • igSetCurrentContext
  • igSetItemAllowOverlap
  • igSetNextWindowSizeConstraints
  • igTreeAdvanceToLabelPos
  • igValueColor
  • igValueColor2
  • ImFontConfig_DefaultConstructor
  • ImGuiIO_ClearInputCharacters

Use va_list or … (problematic)

  • igBulletTextV
  • igLabelTextV
  • igSetTooltipV
  • igTextColoredV
  • igTextDisabledV
  • igTextV
  • igTextWrappedV
  • igTreeNodePtrV
  • igTreeNodeStrV
  • igTreeNodeExV
  • igTreeNodeExPtr
  • igTreeNodeExStr
  • igTreeNodeExVPtr

I think we should ignore the above. You can just use string.Format() and pass that to the single-string overload.

Duplicate imports

  • ImFontAtlas_AddFontDefault
  • igSliderFloat
  • igBeginPopupModal (x2)

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:7 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
mellinoecommented, Jun 4, 2017

I added the missing imports in 93f9e60dafe179ec1c584f369db32b522ec5f674, and published version 0.2.0 onto NuGet.

0reactions
mellinoecommented, Sep 7, 2017

We have complete coverage in the current version we are targeting (1.50), although there are some new functions and breaking changes in 1.51.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Importing playlist info without files & removing duplicates
My question is how can I import the playlist info without the files so ... the playlists will remain, but the file location...
Read more >
Bug: eslint --fix breaks code when airbnb no-duplicate- ...
I am willing to submit a pull request for this issue. Additional comments. when adding the airbnb extension it tries to merge both...
Read more >
react-native link causes duplicate imports in Android ...
For some reason when I call react-native link , it adds duplicate includes to android/settings.gradle which in turn adds duplicate imports to ...
Read more >
Eliminate duplicate during import
I am trying to find a way to import a CSV file which will only create a new story, if there is not...
Read more >
no-duplicate-imports - ESLint - Pluggable JavaScript Linter
A pluggable and configurable linter tool for identifying and reporting on patterns in JavaScript. Maintain your code quality with ease.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found