Make it compatible with Retrofit

I am having issues using this library with Retrofit and GSON.

Since some of the classes, like ZoneId are abstract and GSON can’t create them, I am getting exceptions on Retrofit when I try do deserialize my webservice JSON response.

It would be great to have an adapter that could be plugged into Retrofit to provide GSON the ability to deal with this library.

[JakeWharton]

public @Rfc1123 OffsetDateTime createdAt;

public final class ModelAdapters {
  @FromJson //
  public @Rfc1123 OffsetDateTime rfc1123OffsetDateTimeFromJson(String value) {
    return OffsetDateTime.parse(value, RFC_1123_DATE_TIME);
  }

  @ToJson //
  public String rfc1123OffsetDateTimeToJson(@Rfc1123 OffsetDateTime value) {
    return RFC_1123_DATE_TIME.format(value);
  }
}

Moshi moshi = new Moshi.Builder() //
    .add(new ModelAdapters()) //
    .build();

// ...

.addConverterFactory(MoshiConverterFactory.create(moshi)) //

[JakeWharton]

If you’re using Retrofit you’re using OkHttp which uses Okio which is what Moshi uses which means there’s no intermediate byte[] copies between layers so it’s faster. Most Gson vs. Moshi benchmarks either deal with Strings where it’s slower or actually use a real network where the network behavior contributes instability to the timings.

I can provide example Moshi adapters when I get home.

On Thu, Jan 4, 2018, 9:18 PM feinstein [e-mail] wrote:

When I was searching for JSON solutions I decided to not use Moshi because it appeared to be 2x slower than GSON, at least from this benchmark: https://medium.com/@IlyaEremin/android-json-parsers-comparison-2017-8b5221721e31

Maybe the benchmark was flawed?

I will try Moshi then, if it fixes my issue I can cope with the slower performance. Thank you for the recommendation Jake!

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/JakeWharton/ThreeTenABP/issues/67#issuecomment-355455409, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEEEaESw9FF__g56DfZ__JH4l1mhuBLks5tHYaSgaJpZM4RTQvu .