Running npm install against a shrinkpacked project pushes the local file resolution into the npm cache.

Expected behaviour

It should be possible to rerun shrinkpack if new dependencies have been added to an npm-shrinkwrap file. …

Actual behaviour

shrinkpack detects that some of the dependencies resolve to tarballs in npm_shrinkwrap/ and exits explaining that it has nothing to do.

I think this is the commit containing the faulty logic: https://github.com/JamieMason/shrinkpack/commit/409062cfb7b3ac53a7357de3a1e53bb116b9f054 …

Steps to reproduce

shrinkpack a project add a new dependency try to shrinkpack it again …

Software versions used

OS         :  Linux
node.js    :  v4.2.4
npm        :  v3.8.6
shrinkpack : 0.10.0

Log output when running shrinkpack

! npm-shrinkwrap.json is already shrinkpacked, update it using npm shrinkwrap --dev then try again

Contents of your npm-shrinkwrap.json or package.json

N/A

[marxian]

@lime has it.

Running npm install against a shrinkpacked project pushes the local file resolution into the npm cache. This affects later resolution of the same module, even in different, non-shrinkpacked projects.

Here’s an attempt at demonstrating the issue, sorry if it is hard to follow:

npm cache clean
mkdir test && cd test && npm init -f
npm install --save leftpad

grep -oP \"_resolved\":\".*?\" ~/.npm/leftpad/0.0.0/package/package.json
"_resolved":"https://registry.npmjs.org/leftpad/-/leftpad-0.0.0.tgz"

npm shinkwrap
shrinkpack
npm install

grep -oP \"_resolved\":\".*?\" ~/.npm/leftpad/0.0.0/package/package.json
"_resolved":"file:node_shrinkwrap/leftpad-0.0.0.tgz"

cd .. && mkdir test2 && npm init -f
npm install --save leftpad
npm shrinkwrap
cat npm-shrinkwrap.json
{
  "name": "test2",
  "version": "1.0.0",
  "dependencies": {
    "leftpad": {
      "version": "0.0.0",
      "from": "leftpad@latest",
      "resolved": "file:node_shrinkwrap/leftpad-0.0.0.tgz"
    }
  }
}

[JamieMason]

of course, thanks @DrewML.