yarn workspaces: packages found in node_modules are not excluded when using list/fix-mismatches

Description

Hi, We’re using Yarn Workspaces with the glob pattern packages/**, since we have a deep package tree. Some of the packages have their own node_modules folder with packages inside. Yarn is ok with it and automatically doesn’t search for packages in node_modules.

However, syncpack has its own resolving mechanism and does include packages from node_modules.

Suggested Solution

Automatically exclude node_modules when searching for packages.

Is there a way maybe for a user to exclude it via config? I couldn’t find one.

Thanks!!

[tom-fletcher]

I ran into the same issue with pnpm as my pnpm-workspace.yaml has similar glob patterns such as:

packages:
  - 'apps/**'

As a workaround, you can create a .syncpackrc.js in your project root and perform your own package.json resolution.

For pnpm:

const fs = require('fs')
const glob = require('glob')
const yaml = require('yaml')

let source = ['package.json'] // Include the root package.json

const pnpmWorkspaceFile = fs.readFileSync('pnpm-workspace.yaml', 'utf8')
const workspaces = yaml.parse(pnpmWorkspaceFile)

workspaces.packages.map((workspacePackage) => {
	source = source.concat(
		glob.sync(`${workspacePackage}/package.json`, {
			ignore: `**/node_modules/**`,
		})
	)
})

module.exports = {
	source,
}

And similar for yarn:

const glob = require('glob')

let source = ['package.json'] // Include the root package.json

const packageJson = require('./package.json')
const workspaces = packageJson.workspaces

workspaces.map((workspacePackage) => {
	source = source.concat(
		glob.sync(`${workspacePackage}/package.json`, {
			ignore: `**/node_modules/**`,
		})
	)
})

module.exports = {
	source,
}

However, it would be much nicer if node_modules were always automatically excluded so I will also submit a PR for this.

[JamieMason]

Released in 6.2.1, thanks a lot @tom-fletcher