Optional/Different Arguments regression

CommandAPI version CommandAPI 4.1

Minecraft version 1.14.4

Describe the bug In older versions (eg. 2.3) you could create coexisting sets of arguments, but I cannot get that to work anymore.

My code This code reproduces the behavior:

LinkedHashMap<String, Argument> arguments;

arguments = new LinkedHashMap<String, Argument>();
arguments.put("start", new LiteralArgument("start"));
new CommandAPICommand("mycommand").withArguments(arguments).withPermission(CommandPermission.fromString("hamarb123.mycommand")).executes((sender, args) -> {
    //blah
}).register();

arguments = new LinkedHashMap<String, Argument>();
arguments.put("stop", new LiteralArgument("stop"));
new CommandAPICommand("mycommand").withArguments(arguments).withPermission(CommandPermission.fromString("hamarb123.mycommand")).executes((sender, args) -> {
    //blah
}).register();

Expected behavior It should have all of the command variants that have been registered appearing.

Screenshots

Additional context The documentation at https://www.jorel.dev/CommandAPI/4.1/arguments.html gives the impression that I shouldn’t need any other weird code. Also, the example on the website works properly.

[JorelAli]

@hamarb123 Evening, After having a look at the sample code from your previous comment, I realized you forgot to add .register() to the end of all of your literals! Whoops!!

After adding .register() to the end, I can generate the following:

command_registration.json

    "assassin": {
      "type": "literal",
      "children": {
        "assassins": {
          "type": "literal",
          "children": {
            "add": {
              "type": "literal",
              "children": {
                "players": {
                  "type": "argument",
                  "parser": "minecraft:entity",
                  "properties": {
                    "amount": "multiple",
                    "type": "players"
                  },
                  "executable": true
                }
              }
            },
            "clear": {
              "type": "literal",
              "executable": true
            },
            "list": {
              "type": "literal",
              "executable": true
            },
            "remove": {
              "type": "literal",
              "children": {
                "players": {
                  "type": "argument",
                  "parser": "minecraft:entity",
                  "properties": {
                    "amount": "multiple",
                    "type": "players"
                  },
                  "executable": true
                }
              }
            }
          }
        },
        "mode": {
          "type": "literal",
          "children": {
            "assassin": {
              "type": "literal",
              "executable": true
            },
            "manhunt": {
              "type": "literal",
              "executable": true
            }
          },
          "executable": true
        },
        "query": {
          "type": "literal",
          "children": {
            "enableCompass": {
              "type": "literal",
              "executable": true
            },
            "freezeRange": {
              "type": "literal",
              "executable": true
            }
          }
        },
        "set": {
          "type": "literal",
          "children": {
            "enableCompass": {
              "type": "literal",
              "children": {
                "compassBoolean": {
                  "type": "argument",
                  "parser": "brigadier:bool",
                  "executable": true
                }
              }
            },
            "freezeRange": {
              "type": "literal",
              "children": {
                "distance": {
                  "type": "argument",
                  "parser": "brigadier:integer",
                  "properties": {
                    "min": 1
                  },
                  "executable": true
                }
              }
            }
          }
        },
        "start": {
          "type": "literal",
          "executable": true
        },
        "status": {
          "type": "literal",
          "executable": true
        },
        "stop": {
          "type": "literal",
          "executable": true
        },
        "target": {
          "type": "literal",
          "children": {
            "query": {
              "type": "literal",
              "executable": true
            },
            "set": {
              "type": "literal",
              "children": {
                "player": {
                  "type": "argument",
                  "parser": "minecraft:entity",
                  "properties": {
                    "amount": "single",
                    "type": "players"
                  },
                  "executable": true
                }
              }
            },
            "unset": {
              "type": "literal",
              "executable": true
            }
          }
        }
      }
    },

In Minecraft 1.16.2, using the sample code from the first comment, I was unable to reproduce the issue:

Perhaps it’s a 1.14.4-specific issue? I’ll research later today to see if that’s the case.

[JorelAli]

I personally think having the multiple command executors is quite a useful feature, so don’t plan on dropping it anytime soon ¯_(ツ)_/¯.

You’ve made a few plugins that use the CommandAPI! If you have time to spare, feel free to join my (really really small) Discord server - I’d be honoured to have you on board 😃