IllegalArgumentException before laying out ViewTapTarget on Marshmallow

• I have verified the issue exists on the latest version
• I am able to reproduce it

Version used: 1.6.0

Stack trace:

Process: com.soundcloud.android.debug, PID: 2383 
java.lang.IllegalArgumentException: width and height must be > 0                                                                              
   at android.graphics.Bitmap.createBitmap(Bitmap.java:855)                                                                              
   at android.graphics.Bitmap.createBitmap(Bitmap.java:834)                                                                              
   at android.graphics.Bitmap.createBitmap(Bitmap.java:801)                                                                              
   at com.getkeepsafe.taptargetview.ViewTapTarget$1.run(ViewTapTarget.java:47)                                                                              
   at com.getkeepsafe.taptargetview.ViewUtil$1.onGlobalLayout(ViewUtil.java:60)                                                                              
   at android.view.ViewTreeObserver.dispatchOnGlobalLayout(ViewTreeObserver.java:912)                                                                              
   at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:1981)                                                                              
   at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1119)                                                                              
   at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:6060)                                                                              
   at android.view.Choreographer$CallbackRecord.run(Choreographer.java:858)                                                                              
   at android.view.Choreographer.doCallbacks(Choreographer.java:670)                                                                              
   at android.view.Choreographer.doFrame(Choreographer.java:606)                                                                              
   at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:844)                                                                              
   at android.os.Handler.handleCallback(Handler.java:746)                                                                              
   at android.os.Handler.dispatchMessage(Handler.java:95)                                                                              
   at android.os.Looper.loop(Looper.java:148)                                                                              
   at android.app.ActivityThread.main(ActivityThread.java:5443)                                                                              
   at java.lang.reflect.Method.invoke(Native Method)                                                                              
   at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:728)                                                                              
   at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:618)

Android version: 6.0 Marshmallow

[xiphirx]

I see… Not sure what to do about this at the moment. It seems like an edge case I would need to get more user reports about for it to be worth caring about. I’ll close this issue in the meantime.

[julioz]

I’m guessing it is the result of a race condition. The View I’m targeting is held by an AppBarLayout and the animation I refer to is the expand/collapse animation that happens between states. Interestingly enough, this is the code for the setExpanded method in AOSP:

public void setExpanded(boolean expanded) {
    setExpanded(expanded, ViewCompat.isLaidOut(this));
}

While the following call goes to:

public void setExpanded(boolean expanded, boolean animate) {
    mPendingAction = (expanded ? PENDING_ACTION_EXPANDED : PENDING_ACTION_COLLAPSED)
                | (animate ? PENDING_ACTION_ANIMATE_ENABLED : 0);
    requestLayout();
}

Unfortunately there is this mPendingAction flag that will result in a state change as a consequence of the requestLayout call. As you can see, it is not a simple case as I cannot really control the animation nor the view rendering in that AppBarLayout unfortunately, but it might be the case that the ViewTapTarget is trying to set itself before the completion of the animation in the AppBarLayout. Sometimes it doesn’t happen, though, which makes me believe there is a race condition in there (specially because we’re using a separate Runnable to control GlobalLayouting).