Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

It remove aria-hidden attribute for hidden element on dialog closing

See original GitHub issue

When we open a dialog, it put aria-hidden attribute to true for each element of document other than dialog itself.

And when we close the dialog box, aria-hidden attribute is removed to each of them.

But when an element is aria-hidden="true" yet before opening, a11y-dialog remove the attribute at closing, but it shouldn’t.

Issue Analytics

State:
Created 5 years ago
Comments:10 (5 by maintainers)

Top GitHub Comments

2reactions

patrickhlaukecommented, Oct 9, 2020

this issue should be fixed by the latest change https://github.com/edenspiekermann/a11y-dialog/pull/117

1reaction

kuuakcommented, Jun 17, 2020

Still facing this issue almost 2 years after it has been reported.

If I find some time I’ll try to propose a fix and Pull Request

Top Results From Across the Web

Do I need to use aria-hidden on an element whose visibility ...

Yes, you should add aria-hidden=true to your .page if you're not hiding it with css, but just obscuring it with like z-index ....

aria-hidden - Accessibility - MDN Web Docs - Mozilla

The aria-hidden attribute can be used to hide non-interactive content from the accessibility API. Adding aria-hidden="true" to an element ...

Modals should not have aria-hidden attribute on a dialog ...

My understanding is that Bootstrap overcome this issue by removing aria-hidden="true" dynamically when modal is shown using Javascript (but why ...

Element with aria-hidden has no content in sequential ...

This rule checks that elements with an aria-hidden attribute do not contain elements that are part of the sequential focus navigation and focusable....

Accessible hiding and aria-hidden example

The conventional way is to use CSS ( display:none; and visibility:hidden; ) or the HTML 5 `hidden` attribute. These properties hide elements ......