Custom HttpClient option blocks application shutdown

Calling:

RequestConfig clientConfig = RequestConfig.custom().setConnectTimeout(600000).setSocketTimeout(600000).build();
Unirest.setHttpClient(HttpClientBuilder.create().setDefaultRequestConfig(clientConfig).build());

Which is the default configuration Unirest uses makes the application unable to exit. 8 Threads (I/O dispatcher 1-8) remain running.

[subnetmarco]

I’ve tested this locally and it seems to be fixed with new Unirest version 1.3.3.

Before terminating the application, close the event loop by executing Unirest.shutdown() first. In your example you can use it inside the completed callback function as well.

https://github.com/Mashape/unirest-java#exiting-an-application

[dennisfischer]

2 things: I’ve written the example code and there’s a documentation mistake in the async example. Async examples method failed() has to use UnirestException

The example code - application will never terminate because of http-async-clients created threads:

import com.mashape.unirest.http.HttpResponse;
import com.mashape.unirest.http.JsonNode;
import com.mashape.unirest.http.Unirest;
import com.mashape.unirest.http.async.Callback;
import com.mashape.unirest.http.exceptions.UnirestException;

import java.util.Map;
import java.util.concurrent.Future;

public class Main {
    public Main() {
        Future<HttpResponse<JsonNode>> future = Unirest.post("http://httpbin.org/post")
                .header("accept", "application/json")
                .field("param1", "value1")
                .field("param2", "value2")
                .asJsonAsync(new Callback<JsonNode>() {

                    public void failed(UnirestException e) {
                        System.out.println("The request has failed");
                    }

                    public void completed(HttpResponse<JsonNode> response) {
                        int code = response.getCode();
                        Map<String, String> headers = response.getHeaders();
                        JsonNode body = response.getBody();
                        System.out.println(body);
                    }

                    public void cancelled() {
                        System.out.println("The request has been cancelled");
                    }
                });
    }

    public static void main(String[] args) {
        new Main();
    }
}