Support for Java 8 CompletableFuture

Not sure if this lib is built on JDK 8, but, if it is, it’d be nice to use CompletableFuture instead of the old Future class:

CompletableFuture<HttpResponse<String>> eventualResponse = Unirest.get("http://").asStringFuture();

eventualResponse.thenAccept(response -> {
    //code over here
});

Since Unirest has already a Callback interface, it’d be easy to convert it into a CompletableFuture:

public class CallbackPromise<T> extends CompletableFuture<HttpResponse<T>> implements Callback<T> {
    @Override
    public void completed(HttpResponse<T> response) {
        complete(response);
    }

    @Override
    public void failed(Exception e) {
        completeExceptionally(e);
    }

    @Override
    public void cancelled() {
        completeExceptionally(new UnirestException("cancelled"));
    }
}

[ryber]

@gabfssilva thanks. I’m actually now maintaining an updated fork of this project where I’ve addressed this issue: https://github.com/OpenUnirest/unirest-java

[ryber]

Hello, this should be resolved or addressed in Unirest 2. Please see the upgrade guide for important changes.