question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Bug]: When the ButtonSpecs are left aligned the System Menu icon does not react to the click event any more.

See original GitHub issue

From the investigations of #641: When the ButtonSpecs are “left aligned” the System Menu icon does not react to the click event any more.

ALT+SPACE does popup the system menu though.

Edit: Right click also pop’s up the system menu

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:10 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
giduaccommented, Feb 13, 2022

That could be combined with this request https://github.com/Krypton-Suite/Standard-Toolkit/issues/640

A possible KForm standard that separates the title from the icon and lets title be left/center/right aligned.

For example center the Title: Leave the system menu icon on it’s default spot add (left aligned) ButtonSpecs right next to the sysmenu icon

0reactions
giduaccommented, Mar 3, 2022

Hi (@Smurf-IV @Wagnerp )

Before creating a feature request discussing this a little further here.

Findings: MDI (sample program attached. Needs restoring packages)

The sample program can both add Kform and standard form as child windows. Which clearly shows the differences.

  • It has an RTL Toggle option (to have a look at this)
  • An option to test all the FormBorderStyle variants on the child windows
  • Keyboard combo ALT± (dash) does invoke the system menu on main and child windows

Nightly .43 (without system menu fix and title alignement)

  • left aligned buttonspec
  • system menu on the main window does not react to click and double click
  • child window’s system menu does react to click and double click
  • no left aligned button spec
  • both windows have a fully functional system menu

Nightly .45/.46 (with system menu fix)

  • left aligned buttonspec
  • system menu on the main window does not react to double click
  • child window’s system menu does not react to click and double click
  • no left aligned button spec
  • system menu on the main window does not react to double click
  • both window’s system menu does not react to click and double click

Ribbon

Nightly .43 (without system menu fix and title alignment)

  • App Button visible or not makes no difference
  • AllowFormIntegrate True or False makes no difference
  • The system menu is moved to the right of the QAT Toolbar. The menu does not react to click and double click
  • Double click on the App Button closes the program

Nightly .45/.46 (with system menu fix)

  • App Button visible or not makes no difference
  • AllowFormIntegrate True or False makes no difference
  • The system menu is moved to the right of the QAT Toolbar. The menu does not react to double click
  • Double click on the App Button closes the program

Proposal

System menu always in the outer-left corner (also with RTL == YES) Removes the need to fix the click and double click events Will be a change to devs that now have left aligned ButtonSpecs (how to deal with this)? Looks like nobody hardly ever used left aligned ButtonSpecs. At least one or two should’ve ran in to the defunct system menu.

ButtonSpecs with left alignment: Aligned right to the system menu icon

Form Title placement (already implemented: FormTitleAlign | since nightly .45) side note: RTL = Yes, in a standard form aligns the System menu left and the title right.

Doing it like this would add flexibility. If the Buttonspec needs text/extra (that could interfere with the buttonspec text/extratext) the decision is left to the developer and leaves the option open to others.

If the title is left aligned: It should appear at the first possible position next to the last left aligned Buttonspec.

Also has to be compatible with the Ribbon overlays (In their various guises). How does the above behave in a Ribbon overlay / non overlay / Dynamic overlay (user controlled)

Options:

  • When the system is left aligned (on it’s default spot) The App button when visible would cover it
  • Other apps like Windows Explorer in W10 / WordPad have no App Button and the system menu in the left corner.
  • Not all themes support the KRibbon to be moved onto the title bar or inhibit displaying the App Button.

**3-3-2022 Added: **

Tested with Nightly .62 With(out) buttonspecs: since the fix was introduced for the click event the double-click on the form-icon does not work any more.

MdiApp1.zip

Read more comments on GitHub >

github_iconTop Results From Across the Web

Menu not opening when clicking on react-icons icon
It works right but it has a bug when I click on svg icon inside button, and it does not work, the menu...
Read more >
Start Menu/Windows Explorer not working, can't left click.
Say I open windows start menu with the keyboard. I can't click on any of my pinned programs. But i can tab and...
Read more >
Standard-Toolkit/Documents/Help/Changelog.md at master
Resolved #646, When the ButtonSpecs are left aligned the System Menu icon does not react to the click event any more; Resolved #642,...
Read more >
Icons in context menu are not aligned - Please help
I'm using Firefox Review Theme with few other tweaks (hide container bar and megaurl bar enlargment set to 1px) and everything is fine...
Read more >
tray click is not executed and it shows the context menu ...
Since Electron v3 at least on Linux tray clicking started to show the context menu instead of executing subscribed to tray click event...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found