question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Support for RxJS 6

See original GitHub issue

I’m submitting … [x] Feature request

Current behavior

Using RxJS 5.5.x imports like import { Observable } from 'rxjs/Observable'; are used.

Expected behavior

RxJS 6 brings simplified imports like import { Observable } from 'rxjs'; … so it is necessary to import all classes from directly rxjs.

What is the motivation / use case for changing the behavior?

The problem is the size of a bundled application when the application is using RxJS 6 and a package is using 5.5.x because it is necessary to use rxjs-compat package and load both of them.

Other conditions

If all places in code where angular-modal-gallery is using RxJS imports are manually rewritten to new RxJS import style, everything works so it seems that this change would be very easy to done and the only question is how to manage and publish this package for RxJS 5.5.x and RxJS 6.x in parallel.

Environment (the most important section to fill very carefully)

Angular 6.0.0-rc.3
RxJS 6.0.0-tactical-rc.1

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:5 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
mlc-mlapiscommented, Apr 8, 2018

@Ks89 … ah, sorry. You are right. It was really version 4.0.1.

0reactions
Ks89commented, Apr 8, 2018

Ok perfect, no problem.

Read more comments on GitHub >

github_iconTop Results From Across the Web

RxJS 6.x to 7.x Detailed Change List
This document contains a detailed list of changes between RxJS 6.x and RxJS 7.x, presented in the order they can be found when...
Read more >
RxJS 6: What's new and what has changed? - Auth0
RxJs 6 is out to provide developers with improvements in modularity, a boost in performance and easier to debug call stacks.
Read more >
Angular 6: Upgrading API calls to RxJS 6 - Metal Toad
First, let's consider a service that uses forkJoin to make parallel API calls. The Angular 5/RxJS 5 code looked like this:.
Read more >
RxJS 6 - What Changed? - Academind
RxJS 6 changes everything! Or does it? It certainly breaks your imports and operator usage. Time for some (quick!) fixes!
Read more >
RxJS 6 Release Improves Performance and Modularity - InfoQ
The RxJS team has announced their 6.0 release, which improves the project's approach to modularity, streamlines performance, adds a backward ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found