Python error: deallocating None

Hi,

First, let me thank you for sharing this great tool with the community. I’m using the room impulse response tool to generate a large amount of RIRs to perform data augmentation. Each time I run my script, I get this error at the 19208th call of the function compute_rir():

Current thread 0x00007f0e73bf3700 (most recent call first):
  File "[...]/.local/lib/python3.5/site-packages/numpy/core/_internal.py", line 477 in Stream
  File "[...]/.local/lib/python3.5/site-packages/numpy/core/_internal.py", line 449 in _dtype_from_pep3118
  File "[...]/.local/lib/python3.5/site-packages/numpy/ctypeslib.py", line 436 in as_array
  File "/usr/local/lib/python3.5/dist-packages/pyroomacoustics/room.py", line 652 in image_source_model
  File "/usr/local/lib/python3.5/dist-packages/pyroomacoustics/room.py", line 683 in compute_rir
  File "/usr/local/lib/python3.5/dist-packages/pydsp/simulator.py", line 33 in rir
  File "../batches/rooms_simultator.py", line 67 in <module>
  Fatal Python error: deallocating None

From my understanding, this error might be due to bad deallocation of memory in the C/C++ routine (I know pyroom uses C optimized code to generate RIR faster). Have you ever encounter this issue before?

Thank you,

[fakufaku]

Thanks! Because I could write my own unit test for this and check it failed before and doesn’t fail with bugfix, I’m pretty sure something was fixed. So I pushed a new release (0.1.17). So no need to go through the procedure above, just upgrade through pip (if that is what you use).

I’ll close that for now, but feel free to reopen it in case it didn’t actually fix the problem.

[fakufaku]

Thanks for the details. I’m trying to see if the bug happens for a test case I wrote based on this template.

I am also aware that I am doing some sketchy things with memory allocation in the C extension. I will try to fix this, but it might take a few days. Please hang on.