Provide a way to check a request is timed out before executing a blocking task

Some users want to reject to run a blocking task after a request was timed out. It seems useful to add an option that fails fast when a request was timed out when building a Server

class ServerBuilder {

    public ServerBuilder blockingTaskExecutor(int numThreads, boolean allowExecutingAfterTimeout) {
        if (!allowExecutingAfterTimeout) {
            BlockingTaskExecutor executor = 
                    BlockingTaskExecutor.builder()
                                        .numThreads(numThreads)
                                        .taskFunction(task -> {
                                            return () -> {
                                                 ServiceRequestContext ctx = ServiceRequestContext.currentOrNull();
                                                 if (ctx == null || !ctx.isTimedOut()) {
                                                    task.run();
                                                 }
                                            };
                                        })
                                        .build();
        } else {
            ...
        }
    }

}

[jupiny]

Let me try it 😄 @ikhoon nim.

[ikhoon]

Had a chat with @minwoox and he was concerned that a resource could be leaked if a close() method that should be called is not executed in the task job when taskFunction is used. Alternately, we can wrap a blocking task executor with a decorator.

class TimeoutAwareBlockingTaskExecutor implements BlockingTaskExecutor {
    private final ScheduledExecutorService delegate;

    @Override
    public void execute(Runnable command) {
         ServiceRequestContext ctx = ServiceRequestContext.currentOrNull();
         if (ctx == null || !ctx.isTimedOut()) {
            delegate.execute(command);
         } else {
            throw new RejectedExecutionException("Request has been timed out. ctx: " + ctx);
         }
    }
}

But I wasn’t sure that this is a good first issue. Because we need to check overall implementations that use BlockingTaskExecutor in Armeria. Why don’t you pick up another issue? 😅