Type dependency resolution needed

We tries to sort types by dependencies prior to actual serialization:

https://github.com/Lokad/ILPack/blob/4763b173a0b9f76e4a650a61dfdc9bd1cca1ca31/src/AssemblyGenerator.Types.cs#L47-L54

Dependency solver method:

https://github.com/Lokad/ILPack/blob/4763b173a0b9f76e4a650a61dfdc9bd1cca1ca31/src/AssemblyGenerator.Types.cs#L13-L45

As you see, this method should fail to handle constructed generic types correctly (e.g. IPage in class jot_2 : ICompiledJot<IPage> if all dependent types and jot_2 would be in the same assembly) and throw cyclic dependency exception. Since, our current unit tests are more complex, I’ve tried completely removing the sorting by assuming metadata are already sorted for a given assembly and it worked.

Question: Is my assumption correct? If so, I will remove type dependency resolution completely. If not, I’ll improve it.

[OlegRa]

@vermorel I can confirm that the initial problem was solved completely and the last issue pointed out by @toptensoftware is a duplicate for the #127 that is defined more precisely. I suggest closing this one for now.

[toptensoftware]

I’m pretty sure the cyclic dependency problem is solved and we are reserving all members (including constructors) before creating the types. The problem here is in handling closed generics in the GetConstructorHandle function.

It’s failing to find constructor handle for:

SandboxSubject.MyBase`1[SandboxSubject.Derived] Void .ctor()

Which should get mapped (via a TypeSpec) to:

SandboxSubject.MyBase`1[T] Void .ctor()

ie: this is part of a bigger problem with handling generics and not related to circular dependencies. I think there are many places where this kind of issue isn’t being handled correctly.