Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

PacketSwapBlock#onMessage modifies the world asychronously

See original GitHub issue

The packet handler PacketSwapBlock#onMessage is modifying the world directly from the handler method. Since this method is called from a Netty thread, the world is being modified asynchronously, causing problems with both Vanilla and other mods.

I recommend running this handler on the main thread, using MinecraftServer#addScheduledTask

Issue Analytics

State:
Created 7 years ago
Reactions:6
Comments:8 (5 by maintainers)

Top GitHub Comments

1reaction

mbaxcommented, Nov 1, 2016

If you’re modifying the world in any way, you should be doing that from the main server thread. Also if iterating collections the server uses, or making any calls that might trigger loading any entities/tileentities.

1reaction

mbaxcommented, Oct 30, 2016

Put the entire handling section, not just the spot @Aaron1011 highlighted, into a main thread handler. You have several calls in there that could result in unpleasant or unexpected behavior.