Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Transitive inclusion of `should` mutating Object prototype

See original GitHub issue

One issue with #139 is that v2.9.2 of openapi-spec-converter transitively includes the should package at runtime via swagger2openapi, which mutates the Object prototype and can cause runtime errors. This extends to this package.

I merged a fix to the offending package (https://github.com/Mermade/oas-kit/pull/83) but the issue is that it’s on v3.2.10 now, and I think that needs some work for compatibility. In the meantime, I’ve just been using the following resolutions statement in my package.json:

"api-spec-converter/swagger2openapi": "github:vaskevich/oas-kit#swagger2openapi-v2.9.2-gitpkg"

Issue Analytics

State:
Created 5 years ago
Comments:16 (10 by maintainers)

Top GitHub Comments

1reaction

rbrencommented, Feb 15, 2019

OK - pinned to 2.9.* in api-spec-converter@2.7.31

Thanks for the fix Mike!

1reaction

MikeRalphsoncommented, Feb 15, 2019

“2.9.*” should be safe and allow additional patch releases for api-spec-converter.

Top Results From Across the Web

Why is mutating the [[prototype]] of an object bad for ...

It means that all property lookup optimisations are flushed, and precompiled code will need to be discarded. Or it simply falls back to...

Immutability - University of Washington

To guarantee transitive non-mutability, an object's state must be (transitively) held directly in variables/fields rather than ac- cessed by a pointer. However, ...

Semantics of the Transitive Construction: Prototype Effects ...

This paper investigates whether an abstract linguistic construction shows the kind of prototype effects characteristic of non-linguistic ...

ECMA-262 Edition 5.1 - ECMAScript Language Specification

Every object created by a constructor has an implicit reference (called the object's prototype) to the value of its constructor's “ prototype ”...

Remarks on the basic transitive sentence - ScienceDirect.com

The goal of this paper is to propose a new kind of (specified) prototype that could possibly be more suitable for typological studies...