Very dangerous and unoptimized code inside library!

private static Bitmap getImageResized(Context context, Uri selectedImage) {
        int[] sampleSizes = new int[]{5, 3, 2, 1};
        int i = 0;

        Bitmap bm;
        do {
            bm = decodeBitmap(context, selectedImage, sampleSizes[i]);
            ++i;
        } while(bm != null && (bm.getWidth() < minWidthQuality || bm.getHeight() < minHeightQuality) && i < sampleSizes.length);

        Log.i(TAG, "Final bitmap width = " + (bm != null?Integer.valueOf(bm.getWidth()):"No final bitmap"));
        return bm;
    }

This code is absolutely HORRIBLE for these 3 reasons:

1. Wastes CPU resources by creating up to 4 different bitmaps unnecessarily.
2. Risks OutOfMemory crash by potentially loading a too-large Bitmap into RAM (you don’t check the size from file before loading Bitmap, it might be 100 megapixels as far as I’m concerned)
3. Creates huge memory churn (again, by creating 4 unnecessary Bitmaps) which are then unnecessarily left for Garbage Collector to handle…

Please watch this video to learn how to load images properly from files: https://www.youtube.com/watch?v=HY9aaXHx8yA

I won’t use your library for these reasons.

[Mariovc]

I was just saying that you are free to give a better solution if you think there is a better way to do it. I will take it into account and will try to improve it in the next days/weeks.

Thank you for your comment and your help. And sorry if I was too rude, it wasn’t my intention.

[aranda-adapptor]

@gajicm93 not sure if it will get merged but you can use my branch to get around the issue if you need to.