return true on hasLoadedAllItems not working

I have the following code and loading row is still showing. Why?

@Override
   public void onLoadMore() {
       Log.d("EncryptionPager","onLoadMore");

   }

   @Override
   public boolean isLoading() {
       Log.d("EncryptionPager","isLoading");
       return false;
   }

   @Override
   public boolean hasLoadedAllItems() {
       Log.d("EncryptionPager","hasLoadedAllItems");
       return true;
   }

[4lfant]

Loading row hides only when setHasMoreDataToLoad() method is called.

From RecyclerPaginate.java:

@Override
public void setHasMoreDataToLoad(boolean hasMoreDataToLoad) {
        if (wrapperAdapter != null) {
        wrapperAdapter.displayLoadingRow(hasMoreDataToLoad);
    }
}

The problem is that method is only called when adapter data is changed.

So there are two solutions:

1. When all data is loaded and you want to hide the loading row, get the hasLoadedAllItems() to return true and after this notify the adapter by calling adapter.notifyDataSetChanged();

private class PaginateCallbacks implements Paginate.Callbacks {
        private boolean loading = false;
        private boolean loadedAll = false;

        @Override
        public void onLoadMore() {
            loading = true;
            RetrofitService.getClient().getData()
            .enqueue(new Callback<Data>() {
                        @Override
                        public void onResponse(Call<Data> call, Response<Data> response) {
                            if (response.isSuccessful()) {
                                if (response.body().isEmpty()) {
                                    loadedAll = true;
                                    adapter.notifyDataSetChanged();
                                    return;
                                }
                                data.addAll(response.body());
                                if (response.body().size() < DATA_PORTION_SIZE) {
                                    loadedAll = true;
                                }
                                adapter.notifyDataSetChanged();
                                loading = false;
                            } else {
                                Log.e(TAG, response.errorBody().toString());
                            }
                        }
                        @Override
                        public void onFailure(Call<Data> call, Throwable t) {
                              t.printStackTrace();
                        }
                    });
        }

        @Override
        public boolean isLoading() {
            return loading;
        }

        @Override
        public boolean hasLoadedAllItems() {
            return loadedAll;
        }
}

1. Or manually hide the loading row by calling paginate.setHasMoreDataToLoad(false);

Paginate paginate = Paginate.with(recyclerView, new PaginateCallbacks())
                .setLoadingTriggerThreshold(0)
                .addLoadingListItem(true)
                .build();

And then in callbacks:

private class PaginateCallbacks implements Paginate.Callbacks {
        private boolean loading = false;

        @Override
        public void onLoadMore() {
            loading = true;
            RetrofitService.getClient().getData()
            .enqueue(new Callback<Data>() {
                        @Override
                        public void onResponse(Call<Data> call, Response<Data> response) {
                            if (response.isSuccessful()) {
                                if (response.body().isEmpty()) {
                                    paginate.setHasMoreDataToLoad(false);
                                    return;
                                }
                                data.addAll(response.body());
                                loading = false;
                                if (response.body().size() < DATA_PORTION_SIZE) {
                                    paginate.setHasMoreDataToLoad(false);
                                }
                            } else {
                                Log.e(TAG, response.errorBody().toString());
                            }
                        }
                        @Override
                        public void onFailure(Call<Data> call, Throwable t) {
                              t.printStackTrace();
                        }
                    });
        }

        @Override
        public boolean isLoading() {
            return loading;
        }

        @Override
        public boolean hasLoadedAllItems() {
            return false;
        }
    }

[MarkoMilos]

This has been resolved as a part of the latest release (check out release 1.0.0)

I’m closing this MR, feel free to reopen if you still experiencing this issue.