Retrieving the full request URL

Is your feature request related to a problem? Please describe. Actually, I can get the current path with request.path. It would be great to add:

• request.url with the full request without the query string. Ex: http://example.com
• request.full_url with the full request with the query string. Ex: http://example.com?q=search

[nok]

Yes, please! It’s a good idea and suggestion.

I think that a developer expects these information from a passed request. But we should’t reinvent the wheel. What do you think about furl? It’s flexible and well tested.

Usage:

# app/http/controllers/HelloWorldController.py

"""A HelloWorldController Module."""

from masonite.response import Response
from masonite.request import Request
from masonite.controllers import Controller


class HelloWorldController(Controller):
    """HelloWorldController Controller Class."""

    def show(self, request: Request, response: Response):
        furl = request.furl.asdict()
        return response.json(furl)

Response:

{
    "fragment": {
        "encoded": "",
        "path": {
            "encoded": "",
            "isabsolute": [],
            "isdir": true,
            "isfile": false,
            "segments": []
        },
        "query": {
            "encoded": "",
            "params": []
        },
        "separator": true
    },
    "host": "localhost",
    "host_encoded": "localhost",
    "netloc": "localhost:8000",
    "origin": "http://localhost:8000",
    "password": null,
    "path": {
        "encoded": "/hello",
        "isabsolute": true,
        "isdir": false,
        "isfile": true,
        "segments": [
            "hello"
        ]
    },
    "port": 8000,
    "query": {
        "encoded": "",
        "params": []
    },
    "scheme": "http",
    "url": "http://localhost:8000/hello",
    "username": null
}

Implementation:

# masonite/request.py


from furl import furl
# [...]

class Request(Extendable):
    # [...]

    @property
    def furl(self) -> furl.furl:
        full_url = self.environ.get('APP_URL') + self.path  # <--- here we have to pass the full url
        return furl(full_url)

We can use this blueprint as a starting point.

[josephmancuso]

https://github.com/MasoniteFramework/masonite/pull/317