Initial rope error notification is uninformative

Environment data

• VS Code version: 1.25.1 1dfc5e557209371715f655691b1235b6b26a06be x64
• Extension version (available under the Extensions sidebar): 2018.7.1 (23 July 2018)
• OS and version: Mac OS High Sierra 10.13.6 (17G65)
• Python version (& distribution if applicable, e.g. Anaconda): XXX
• Type of virtual environment used: venv
• Relevant/affected Python packages and their versions: rope

Actual behavior

When rope fails to refactor, an error notification appears with Cannot perform refactoring using selected element(s).... Which doesn’t help debug the situation

Expected behavior

The error notification should already include the helpful error information. in this case Refactor failed. invalid Syntax in...

Steps to reproduce:

1. Open a python file
2. Insert code with a syntax error. i/e a++
3. Select the code and try to extract a variable
4. Open the notification to show the full error log and the actual helpful info

Logs

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

##########Refactor Output##########
Error in refactoring:
Refactor failed. Syntax error in file <server/push_notifications/__init__.py> line <23>: invalid syntax
[<FrameSummary file refactor.py, line 294 in watch>, <FrameSummary file refactor.py, line 279 in _process_request>, <FrameSummary file refactor.py, line 223 in _extractVariable>, <FrameSummary file refactor.py, line 117 in refactor>, <FrameSummary file refactor.py, line 163 in onRefactor>, <FrameSummary file /Users/tomer/hub/venv/lib/python3.6/site-packages/rope/refactor/extract.py, line 68 in get_changes>, <FrameSummary file /Users/tomer/hub/venv/lib/python3.6/site-packages/rope/refactor/extract.py, line 101 in __init__>, <FrameSummary file /Users/tomer/hub/venv/lib/python3.6/site-packages/rope/base/project.py, line 116 in get_pymodule>, <FrameSummary file /Users/tomer/hub/venv/lib/python3.6/site-packages/rope/base/pycore.py, line 142 in resource_to_pyobject>, <FrameSummary file /Users/tomer/hub/venv/lib/python3.6/site-packages/rope/base/pycore.py, line 255 in get_pymodule>, <FrameSummary file /Users/tomer/hub/venv/lib/python3.6/site-packages/rope/base/pyobjectsdef.py, line 162 in __init__>, <FrameSummary file /Users/tomer/hub/venv/lib/python3.6/site-packages/rope/base/pyobjectsdef.py, line 191 in _init_source>]

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help)

workbench.main.js:sourcemap:2364 Cannot perform refactoring using selected element(s). (Refactor failed. Syntax error in file <server/push_notifications/__init__.py> line <23>: invalid syntax [<FrameSummary file refactor.py, line 294 in watch>, <FrameSummary file refactor.py, line 279 in _process_request>, <FrameSummary file refactor.py, line 223 in _extractVariable>, <FrameSummary file refactor.py, line 117 in refactor>, <FrameSummary file refactor.py, line 163 in onRefactor>, <FrameSummary file /Users/tomer/hub/venv/lib/python3.6/site-packages/rope/refactor/extract.py, line 68 in get_changes>, <FrameSummary file /Users/tomer/hub/venv/lib/python3.6/site-packages/rope/refactor/extract.py, line 101 in __init__>, <FrameSummary file /Users/tomer/hub/venv/lib/python3.6/site-packages/rope/base/project.py, line 116 in get_pymodule>, <FrameSummary file /Users/tomer/hub/venv/lib/python3.6/site-packages/rope/base/pycore.py, line 142 in resource_to_pyobject>, <FrameSummary file /Users/tomer/hub/venv/lib/python3.6/site-packages/...

[brettcannon]

Closing as we plan to add refactoring to our language server, negating the need for Rope.

[Tadaboody]

You give me too much credit 😜