Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
Allow users to plug in their own HTTP headers validator
See original GitHub issueWe’ve been looking into ways to ensure a better support to HTTP header names as defined in RFC7230, Section 3.2.6 in Finagle. Today’s header validation rules in Netty (as per DefaultHttpHeaders.java) don’t prohibit ASCII delimiters (e.g., []), and, unfortunately, there is no easy way to to configure it otherwise.
One way to do that would be make a DefaultHttpHeaders constructor that also takes NameValidator public. This should allow users to opt-in for RFC7230 headers in their application code. HTTP codecs (think inbound HTTP messages), however, will still be using a default validator. Perhaps, allowing users to configure a NameValidator for HTTP codecs is a way to approach this.
I’m curious what do people think about this?
Issue Analytics
- State:
- Created 5 years ago
- Reactions:6
- Comments:17 (16 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
@normanmaurer Maybe we can include this ticket into the Netty 5 roadmap? We’ll have more room for maneuver there and, perhaps can actually support RFC7230 out of the box.
I like the strict mode idea. As long as users would be able to opt-in for “more valid” headers (either by writing their own validator or switching over to strict) I’m happy.