Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

netty should strip the http2-setting header

See original GitHub issue

Expected behavior

HTTP2-Settings is a magic header that embeds the http/2 settings in the h2c upgrade request. After it’s read by the upgrade handler in netty, it should be removed.

Actual behavior

Instead it’s turned into a header in the http/2 headers, and gets propagated to the application, which can make implementing an h2c proxy complicated.

Steps to reproduce

Make an h2c proxy in netty, or examine an h2c upgrade request after it’s converted to an http/2 request in Http2MultiplexCodec.

Netty version

4.1.16.Final

JVM version (e.g. `java -version`)

jdk8

OS version (e.g. `uname -a`)

osx, linux

Issue Analytics

State:
Created 6 years ago
Comments:7 (6 by maintainers)

Top GitHub Comments

1reaction

carl-mastrangelocommented, Dec 5, 2017

@mossen I haven’t heard of that header before, is it in an RFC ?

0reactions

normanmaurercommented, Jan 15, 2018

Thanks for closing the loop

Top Results From Across the Web

Netty HTTP/2 Configuration · Issue #4197 - GitHub

I'm trying to set up a Netty client to communicate with Jetty's H2C (HTTP/2) server. I have the server running on localhost at...

HTTP/2 in Netty | Baeldung

Learn how to implement an HTTP/2 server and client in Netty using code ... Netty handles the exchange of HEADERS, DATA and SETTINGS...

Http2Settings (Netty API Reference (4.1.85.Final))

Settings for one endpoint in an HTTP/2 connection. Each of the values are optional as defined in the spec for the SETTINGS frame....

RFC 7540 - Hypertext Transfer Protocol Version 2 (HTTP/2)

Since the upgrade is only intended to apply to the immediate connection, a client sending the HTTP2-Settings header field MUST also send HTTP2-Settings...

io.netty.handler.codec.http2.DefaultHttp2Headers.scheme java code ...

headers.path(request.uri()); headers.authority(request.headers().get("host")); headers.scheme("http"); request.headers().remove("http2-settings"); ...