Problem with big decimal field on table creation

QueryFailedError: 🔨 Not supported 🔨 : The query you ran generated an AST which parts have not been read by the query planner. This means that those parts could be ignored:
    
        ⇨ .columns[6].dataType.config ([200,2])
    
    👉 pg-mem is work-in-progress, and it would seem that you've hit one of its limits.
    
    *️⃣ Failed SQL statement: 
    CREATE TABLE "public"."activity" (
      ... [ redacted ] ...
      "amount" numeric(200,2), 
      ... [ redacted ] ...
    );
    
        at new QueryFailedError (.../src/error/QueryFailedError.ts:9:9)
        at .../src/driver/postgres/PostgresQueryRunner.ts:188:30
        at Timeout._onTimeout (.../node_modules/pg-mem/src/adapters.ts:123:42)
        at listOnTimeout (internal/timers.js:554:17)
        at processTimers (internal/timers.js:497:7) 

[oguimbal]

Hi, It would be easy to implement it naïvely, meaning that table creation would work, and usual operations as well.

BUT, doing that would not implement the actual behaviour of numeric, which is quite complex.

This would mean that you could get inconsistent results (numbers would not be truncated to the defined numeric precision, “Infinity” and “NaN” would not exist, …) 👉 These numbers would not behave exactly as actual postgres numeric values, and your tests might not behave as expected 🤷‍♂️

So, just a quick poll (anyone can answer): Vote 👍 if it would be of any use to implement that naïve version Vote 👎 if it’s useless, and you want to wait until I have enough time to implement a real numeric type

[oguimbal]

Now that I think about it, this workaround should work as well:

const db = newDb();
db.public.interceptQueries(sql => {
    const newSql = sql.replace(/\bnumeric\s*\(\s*\d+\s*,\s*\d+\s*\)/g, 'float');
    if (sql !== newSql) {
         return db.public.many(newSql);
    }
    // proceed to actual SQL execution for other requests.
    return null;
});

This should replace all numeric(x,y) instances in the executed queries with float.

And at least, if you copy-paste that, you know that you’re doing something wrong for your numeric types 😄

disclaimer: not tested 😃

disclaimer 2: dont try to insert strings that contain numeric(x,y) 😅

Tell me if it works… (it is in fact equivalent to the naive implementation) If it does, i’ll wait