Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Frame visibility in sitemap ignored

See original GitHub issue

PR #1174 looks to be included in 2.7.10-beta, so it may have caused this, or it isn’t included and may fix this issue.

Actual behaviour

Sitemaps with items that should be hidden are always visible. Basic UI displays them properly.

Expected behaviour

Sitemaps with items that should be hidden should be hidden.

Steps to reproduce

Add Item1 to a sitemap inside a frame with visibility based on Item2.
Toggle Item2 and notice visibility of Item1 does not change.

Here is a snip from the sitemap where I see this occurring…

    Frame visibility=[Mode=="Morning"] {
        Switch item=Wakeup_Alarm
        Switch item=Wakeup_Alarm_Snooze
    }

Environment data

Client

Android version: 2.7.10-beta

Server

Server version: S1627

Issue Analytics

State:
Created 4 years ago
Comments:21 (12 by maintainers)

Top GitHub Comments

1reaction

maniac103commented, Aug 5, 2019

I think so, yes.

0reactions

maniac103commented, Sep 2, 2019

Is the label required?

It looks like that’s the case currently. We internally filter out frames without label for whatever reason. Since I don’t understand the rationale for this either, I created #1502 which changes the behavior to just hide the label in that case, but keep the frame widget:

Screenshot_1567418755