question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

【 2 + 1 Suggestions】The eslint config of PIXI.js is too much strict .

See original GitHub issue

One : “no-unmodified-loop-condition”

I have a function like this :

funcA(loopMoreThanOnce)
{
    //  .....
    do {
        //  .....
    } while (loopMoreThanOnce);
    //  .....
}

This funcA is reasonable. But because "no-unmodified-loop-condition": 1 , I have to write the code very ugly like this :

funcA(loopMoreThanOnce)
{
    //  .....
    let flag;
    do {
        flag = loopMoreThanOnce;
        //  .....
    } while (flag);
    //  .....
}

Could you remove it please ?

Two : “func-names”

Because of "func-names": [1, "always"]

When I want to define a function have to write like this :

const funcName = function funcName()
{

}

The name on right side is unnecessary and stupid.

Could you remove it please ?

Three : “quote-props” & “dot-notation”

I want to use 'key' for the same object , but because "quote-props": [1, "as-needed"] & "dot-notation" : 1 , I can’t use Uniform Style in my code:


// look at the keys : 
        this.compositeOperations = {
            'source-over': [gl.ONE, gl.ONE_MINUS_SRC_ALPHA, 1],
            lighter: [gl.ONE, gl.ONE_MINUS_SRC_ALPHA, 0],
            lighten: [gl.ONE, gl.ONE_MINUS_SRC_ALPHA, 0],
            darker: [gl.DST_COLOR, gl.ONE_MINUS_SRC_ALPHA, 1],
            darken: [gl.DST_COLOR, gl.ONE_MINUS_SRC_ALPHA, 1],
            'destination-out': [gl.ZERO, gl.ONE_MINUS_SRC_ALPHA, 1],
            'destination-over': [gl.ONE_MINUS_DST_ALPHA, gl.ONE, 1],
            'source-atop': [gl.DST_ALPHA, gl.ONE_MINUS_SRC_ALPHA, 1],
            xor: [gl.ONE_MINUS_DST_ALPHA, gl.ONE_MINUS_SRC_ALPHA, 1],
            copy: [gl.ONE, gl.ZERO, 1],
            'source-in': [gl.DST_ALPHA, gl.ZERO, 1],
            'destination-in': [gl.ZERO, gl.SRC_ALPHA, 1],
            'source-out': [gl.ONE_MINUS_DST_ALPHA, gl.ZERO, 1],
            'destination-atop': [gl.ONE_MINUS_DST_ALPHA, gl.SRC_ALPHA, 1],
        };

obj['source-over'];
obj.lighter;
obj.lighten;
obj.darker;
obj.darken;
obj['destination-out'];
obj['destination-over'];
obj['source-atop'];
obj.xor;
obj.copy;
obj['source-in'];
obj['destination-in'];
obj['source-out'];
obj['destination-atop'];


Issue Analytics

  • State:closed
  • Created 7 years ago
  • Comments:15 (12 by maintainers)

github_iconTop GitHub Comments

1reaction
themoonratcommented, Dec 10, 2016

Hi finscn. Sorry you don’t like it, but as BossLevel, it’s an extra method name for the sake of extra debugging information. I’m sure you can understand why, given a choice, developers of a library might choose ease of debugging over more concise syntax.

0reactions
lock[bot]commented, Feb 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Read more comments on GitHub >

github_iconTop Results From Across the Web

【Share】A new Animation Class for PIXI.js #3469 - GitHub
More detail see the first suggestion in 【 2 + 1 Suggestions】The eslint config of PIXI.js is too much strict . #3434.
Read more >
@pixi/eslint-config - npm
ESLint config for PixiJS plugin creators. Latest version: 4.0.1, last published: 6 months ago. Start using @pixi/eslint-config in your ...
Read more >
rushstack/rushstack - Gitter
Hello. I am migrating my monorepo from lerna/yarn workspaces to rush. Need help. Struggling with publishing my shared packages to npm registry.
Read more >
Upgrading to a stricter ESLint config - Thibaud's blog
Updating a codebase from one ESLint config to another can be daunting, especially if switching to something more strict.
Read more >
I don't like prettier : r/javascript - Reddit
Like, a project with several repositories in Java. Oh, this one? We'll indent with 4 spaces. The next? 2 spaces. Gotta configure your...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found