Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

html: Closing > put on newline

See original GitHub issue

Prettier 1.15.3 Playground link

--parser html

Input:

<!DOCTYPE html>
<div>
  <div>
    <div>
      <div>
        <div>
          <div>
            <div>
              Response body
              <textarea
                name="readinessProbe.response.body"
              >{{ readinessProbe.response.body }}</textarea>
            </div>
          </div>
        </div>
      </div>
    </div>
  </div>
</div>

Output:

<!DOCTYPE html>
<div>
  <div>
    <div>
      <div>
        <div>
          <div>
            <div>
              Response body
              <textarea name="readinessProbe.response.body">
{{ readinessProbe.response.body }}</textarea
              >
            </div>
          </div>
        </div>
      </div>
    </div>
  </div>
</div>

Expected behavior: Not to change the input. The input comes from 1.15.2.

</textarea
>

That part is the thing I’m reporting, if the amount if divs were confusing 😅

html-whitespace-sensitivity doesn’t matter, btw

Issue Analytics

State:
Created 5 years ago
Reactions:1
Comments:5 (5 by maintainers)

Top GitHub Comments

1reaction

SimenBcommented, Dec 3, 2018

Ah, alright! You learn something every day 🙂 Thanks for the detailed response

0reactions

ikatyangcommented, Dec 2, 2018

Is it related to that? This is closing > on the closing tag, not the opening tag.

Since --jsx-bracket-same-line is defined as “do not put > alone on the next line”, #5377 should track it for both opening and closing tags.

That said, we should probably use another parser, even though I’d expect the content of a textarea to just be treated as plain text in the html parser

If you intend to use it as an interpolation, you should use one of the parser that supports interpolation since there’s a special rule for <textarea> in the HTML spec that the first LF will be ignored in <textarea>. That said, the following formatting can be unsafe based on the value of the interpolation:

<!-- before -->
<textarea>{{something}}

<!-- after -->
<textarea>
{{something}}

It’ll break the output if {{something}} is interpolated as something starts with LF since there will be two LF and only the first one will be ignored, causes an extra LF.

And also, continuous whitespaces in <textarea> can not be collapsed but it’s not the case for interpolations.