unable to find required configuration setting: GCP Project

The new auth config validation is causing deployments to break that do not set the default gcp:project key.

Initial thoughts:

This chunk of code is too zealous and we can begin by removing it and roll the error into the gcloud config validation below: https://github.com/pulumi/pulumi-gcp/blob/master/provider/resources.go#L187 That will fix things for users who have non-default settings.

We can then look into how the underlying provider works - exactly how the GCP project is required and under which circumstances

If necessary/unaccounted for in the auth helper library, we should add validation tests that take into account all authentication scenarios.

[guineveresaenger]

Upstream, incidentally, does not enforce this as a requirement either - so we may never need/want to make it required.

I like the warning-and-continue approach very much as well. Thank you @snamber!

[snamber]

Background: I posted about this issue in the Slack channel

In the end this is just a breaking change that requires (when using the automation API) a few lines of code and in the case of a custom configuration in interactive mode potentially also one line of code, but this line is even suggested in the error message.

v6.36.0 of the pulumi-gcp plugin works after adding this snippet, individual resources can still be created in different projects.

s, err := auto.UpsertStackInlineSource(ctx, stackName, p.Project, deployFunc)
if err != nil {
    ...
}
if err := s.SetAllConfig(ctx, map[string]auto.ConfigValue{
    "gcp:project": {Value: p.Project},
    }); err != nil {
    ...
}

I can see in the documentation that gcp:project is a required field. Maybe this requirement was just never enforced, but it seems to be according to the specification, so while this may break people’s existing configs, these configs seem not to have been to spec in that case.

Maybe as an alternative to rolling back completely an additional line warning of this potential breaking change in the release notes / changelog would also do to point people in the right direction.