Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
puppeteer-core types differ from puppeteer
See original GitHub issueI’m maintaining the puppeteer add-on ghost-cursor and while upgrading the dependency to puppeteer@7 I noticed some strange differences between puppeteer and puppeteer-core types. For example the Page class is not interchangeable:
error TS2345: Argument of type 'import("node_modules/puppeteer/lib/types").Page' is not assignable to parameter of type 'import("node_modules/puppeteer-core/lib/types").Page'.
Types have separate declarations of a private property '_closed'.
Strange enough I can’t find the differences in the generated types.d.ts files:
$ diff node_modules/puppeteer/lib/types.d.ts node_modules/puppeteer-core/lib/types.d.ts | wc -l
0
Any idea how this can be fixed? I would prefer to keep using puppeteer-core in the library while users most of the time use the regular puppeteer library.
Issue Analytics
- State:
- Created 3 years ago
- Reactions:14
- Comments:7
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
This is because
import('puppeteer').Pageandimport('puppeteer-core').Pageare two different classes defined in two different js files from two different modules (so are the two types in two d.ts files). I am wondering whypuppeteerdoesn’t importpuppeteer-coreas a dependency and re-use the classes frompuppeteer-core.This is still an issue.