Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Two 'sgrid' functions when we only need one?

See original GitHub issue

As pointed out in PR #617, there are now two sgrid functions in the package: grid.py:sgrid and rlocus.py:_sgrid_func. It looks like _sgrid_func was removed in PR #193 (discrete omega-damping plot and tweaks by Sup3rGeo), but was re-introduced in PR #209 (sisotool and dynamic root locus zoom by icam0).

Issue Analytics

State:
Created 2 years ago
Comments:13 (13 by maintainers)

Top GitHub Comments

1reaction

bnavigatorcommented, Aug 16, 2021

I am not sure about this. Maybe you can shuffle around existing axes objects together with a newly created parasite axis using the right combination of delaxes(ax), fig.add_subplot(ax), etc.

1reaction

sawyerbfullercommented, Aug 16, 2021

Hi bill, I’ve never seen them used anywhere else, and as private functions I think you can delete them if they don’t show up in anywhere else in the library.

On Sun, Aug 15, 2021 at 2:54 PM Bill Tubbs @.***> wrote:

Question. I’m in the process of replacing _sgrid_func with sgrid and I noticed that _sgrid_func uses two other functions in rlocus.py:

https://github.com/python-control/python-control/blob/6b7a9c78f16ab04e009be7155308294080d8a5d1/control/rlocus.py#L712-L718

https://github.com/python-control/python-control/blob/6b7a9c78f16ab04e009be7155308294080d8a5d1/control/rlocus.py#L750-L754

Shall I delete these functions (they were only used by _sgrid_func) or should these features be carried over?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/python-control/python-control/issues/634#issuecomment-899114690, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN74SSONX6UL556R6PH4OGDT5AZPNANCNFSM46YOSZAQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

– Sawyer Fuller Assistant Professor of Mechanical Engineering Adjunct, Paul G Allen School of Computer Science University of Washington http://faculty.washington.edu/~minster/

(Typed with my thumbs)