`SignMessageLib` is not trusted for delegatecall opcode
See original GitHub issueDescribe the bug
Currently SignMessageLib
contract that is used for on-chain message signing isn’t in delegatecall allowlist and the UI shows a warning.
We need to add the contract to list of trusted addresses:
- old version: https://github.com/gnosis/safe-deployments/blob/e9041df9339c5cbe791a450abd6a2595619c2735/src/assets/v1.3.0/sign_message_lib.json
- recent version: https://github.com/gnosis/safe-deployments/blob/main/src/assets/v1.3.0/sign_message_lib.json
To Reproduce https://gnosis-safe.io/app/rin:0xEAa3b5dB83b5737C085e4DA2f5f45199e3ac1382/transactions/queue
Expected behavior NO warning is shown
Requirements
- use the Safe logo
- use “Gnosis Safe: Sign Message Library” as name
- add Etherscan tag (@johannesmoormann)
Issue Analytics
- State:
- Created 2 years ago
- Comments:13 (13 by maintainers)
Top Results From Across the Web
safe-contracts/SignMessageLib.spec.ts at main - GitHub
safe-contracts/test/libraries/SignMessageLib.spec.ts ... it('can be used only via DELEGATECALL opcode', async () => {. const { lib } = await setupTests().
Read more >Difference between CALL, CALLCODE and DELEGATECALL
DELEGATECALL is a security risk for the sending contract which needs to trust that the receiving contract will treat the storage well. DELEGATECALL...
Read more >Address 0xa6b71e26c5e0845f74c812102ca7114b6a896ab2
@param to Contract address for optional delegate call. ... 'byte' is not working due to the Solidity parser, so lets // use the...
Read more >Chapter 9: Smart Contract Security - DELEGATECALL - 书栈网
This feature enables the implementation of libraries, allowing developers to deploy reusable code once and call it from future contracts.
Read more >Solidity: Events triggered but state not updated after delegatecall
I think there's some confusion about what delegatecall does. It executes the code of another contract in the context of the current transaction....
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
regarding the name tags I will speak to @lukasschor. it would be good to know whether there are more contracts that we should add, as I currently only have a list “List of known contracts (wip)” where SignMessageLib is not mentioned. looking at our contract names I would suggest something like: “Gnosis Safe: Sign Message” or “Gnosis Safe: Sign Message Library”
@liliya-soroka It should be already available on staging and production (every network)