question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

`SignMessageLib` is not trusted for delegatecall opcode

See original GitHub issue

Describe the bug Currently SignMessageLib contract that is used for on-chain message signing isn’t in delegatecall allowlist and the UI shows a warning.

We need to add the contract to list of trusted addresses:

To Reproduce https://gnosis-safe.io/app/rin:0xEAa3b5dB83b5737C085e4DA2f5f45199e3ac1382/transactions/queue

Expected behavior NO warning is shown

Requirements

  • use the Safe logo
  • use “Gnosis Safe: Sign Message Library” as name
  • add Etherscan tag (@johannesmoormann)

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:13 (13 by maintainers)

github_iconTop GitHub Comments

1reaction
johannesmoormanncommented, Dec 9, 2021

regarding the name tags I will speak to @lukasschor. it would be good to know whether there are more contracts that we should add, as I currently only have a list “List of known contracts (wip)” where SignMessageLib is not mentioned. looking at our contract names I would suggest something like: “Gnosis Safe: Sign Message” or “Gnosis Safe: Sign Message Library”

0reactions
Uxio0commented, Dec 14, 2021

@liliya-soroka It should be already available on staging and production (every network)

Read more comments on GitHub >

github_iconTop Results From Across the Web

safe-contracts/SignMessageLib.spec.ts at main - GitHub
safe-contracts/test/libraries/SignMessageLib.spec.ts ... it('can be used only via DELEGATECALL opcode', async () => {. const { lib } = await setupTests().
Read more >
Difference between CALL, CALLCODE and DELEGATECALL
DELEGATECALL is a security risk for the sending contract which needs to trust that the receiving contract will treat the storage well. DELEGATECALL...
Read more >
Address 0xa6b71e26c5e0845f74c812102ca7114b6a896ab2
@param to Contract address for optional delegate call. ... 'byte' is not working due to the Solidity parser, so lets // use the...
Read more >
Chapter 9: Smart Contract Security - DELEGATECALL - 书栈网
This feature enables the implementation of libraries, allowing developers to deploy reusable code once and call it from future contracts.
Read more >
Solidity: Events triggered but state not updated after delegatecall
I think there's some confusion about what delegatecall does. It executes the code of another contract in the context of the current transaction....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found