Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Rating: RatingIcon has tabindex=0 when parent Rating component is disabled

See original GitHub issue

Bug Report

Steps

<Rating rating={1} maxRating={5} disabled size="large" />

Expected Result

Since the parent <Rating> component is disabled, it doesn’t make sense to be able to use the keyboard to focus the individual rating icons.

Actual Result

The individual rating icons have tabindex=0 so they can be reached via the keyboard.

Version

0.83.0

Testcase

https://codesandbox.io/s/7kww573lvx

Issue Analytics

State:
Created 5 years ago
Comments:6 (3 by maintainers)

Top GitHub Comments

1reaction

Fabianopbcommented, Nov 26, 2018

PR created! 😃

0reactions

AndrewLanecommented, Nov 30, 2018

Thank you!

Top Results From Across the Web

tabindex -1 not working for child elements - Stack Overflow

Setting tabindex="-1" allows you to set an element's focus with script, but does not put it in the tab order of the page....

ESRB Ratings | Entertainment Software Ratings Board

ESRB ratings provide information about what's in a game or app so parents and consumers can make informed choices about which games are...

Parent reviews, Family reviews | Common Sense Media

Get age appropriate reviews of movies, books, apps, TV shows, video games, websites, youtube, and podcasts by our expert editors.

Rating control in Power Apps - Microsoft Learn

A control with which users can indicate a value between 1 and a maximum number that you specify. Description. In this control, the...

Age-Appropriate Media: Can You Trust Parental Guidance ...

Studies show that government and industry movie ratings have become more lenient over time. More violent and sexually explicit content are allowed into...