question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

keepOriginalTimestamps will not adjust caption and ID3 timestamps in a future mux.js version

See original GitHub issue

👋 I’m currently working on https://github.com/videojs/mux.js/pull/213, which we plan to release as a new major version once merged.

As I understand it, Shaka uses mux.js to transmux TS to mp4 on platforms without native HLS support, and uses the cea-608 captions parsed out from the segments as well? The PR I linked will no longer adjust caption timings when the keepOriginalTimestamps is set, as the timing adjustment may not actually be accurate when using the original timestamps.

I plan to post in this issue when the major version of mux.js is released, so the dependency version can be locked down if necessary.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:5 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
joeyparrishcommented, Aug 14, 2018

Gotcha. Thanks! We’ll keep an eye on that as we work on upgrading.

I’ll go ahead and close the issue.

1reaction
ismenacommented, Aug 13, 2018

Thanks a lot for letting us know! Yes, we are using mux.js.

@michellezhuogg could you please take a look, see what the impact is going to be for us?

@joeyparrish FYI

Read more comments on GitHub >

github_iconTop Results From Across the Web

keepOriginalTimestamps will not adjust caption and ID3 ...
As I understand it, Shaka uses mux.js to transmux TS to mp4 on ... not adjust caption and ID3 timestamps in a future...
Read more >
mux - Source code - Greasy Fork
* Splits an incoming stream of binary data into ADTS and ID3 Frames. */; AacStream = function() ...
Read more >
Bitmovin-Mux Web SDK v5.4.0 Release
Mux has released version 7.0.0 of its NodeJS SDK. This release fixes some type issues for customers using TypeScript, and adds some missing...
Read more >
shaka-player | Yarn - Package Manager
Important: This documentation covers modern versions of Yarn. For 1.x docs, see classic.yarnpkg.com. Yarn.
Read more >
Team:Estonia TUIT/videojs - iGEM 2020
hasOwnProperty(e))throw new Error('"'+e+'" in not a valid log ... to `true` is deprecated and default to `false` in future version of video.js'),t=!0),this.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found