Add support for new controlHint and labelHint properties in back-end
See original GitHub issueThis is a…
[x] Feature request
[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Documentation issue or request
The problem
We have support for these new properties in our form factory provider service, but until they are “a thing” in the back-end we can’t use them in our model driven forms.
Until this happens, and after https://github.com/syndesisio/syndesis/pull/1664/ has been merged, we’ll notice a “regression” in our model driven forms where what used to be tooltip text attached and duplicated across a label and its form control counterpart will become description text that renders below a given form control.
Merging https://github.com/syndesisio/syndesis/pull/1664/ before this is in place will cause our model driven forms to come out of sync with our UX designs until these properties are updated to use the new *correct property names in the various *.json files.
It’s the last puzzle piece for resolving https://github.com/syndesisio/syndesis/issues/992
Expected behavior
The properties labelHint
and controlHint
in app/connector/activemq/src/main/resources/META-INF/syndesis/connector/activemq.json
and similar type files, should be provided as part of the payload with the rest of the form properties.
Screenshot
API Endpoints and Schemas
/api/v1/connectors
Tasks involved / Steps to Reproduce
- Specify a
labelHint
property inapp/connector/activemq/src/main/resources/META-INF/syndesis/connector/activemq.json
for any form property, for examplebrokerUrl
- Begin watching network traffic in your browser dev tools
- Begin adding an AMQ connection, and when you get to the configuration screen, notice the tooltip doesn’t show up
- Also notice the call to
https://syndesis.x.x.x.x.nip.io/api/v1/connectors
didn’t return the new property.
Issue Analytics
- State:
- Created 6 years ago
- Comments:10 (10 by maintainers)
Top GitHub Comments
@seanforyou23 the backend needs to add those fields to
ComponentDefinition.Property
interface. Working on it now.I just referenced #992 when I posted the PR since it was pretty much leftovers from that work anyway. Hope that’s ok.