[Bug]: `readdir` implementations don't accept `null` as second argument

Self-service

• I’d be willing to implement a fix

Describe the bug

The readdir implementations in @yarnpkg/fslib don’t accept null as the second argument (which is supported by Node) and throw a cryptic:

TypeError: Cannot destructure property 'withFileTypes' of '(intermediate value)(intermediate value)(intermediate value)' as it is null.

To reproduce

await packageJsonAndInstall({});

await expect(
  yarn(`node`, `-e`, `require('fs').readdirSync('.', null)`)
).resolves.toBeTruthy();

Environment

System:
    OS: Linux 5.13 Arch Linux
    CPU: (32) x64 AMD Ryzen 9 5950X 16-Core Processor
  Binaries:
    Node: 16.0.0 - /tmp/xfs-62396191/node
    Yarn: 3.0.1-rc.1.dev - /tmp/xfs-62396191/yarn
    npm: 7.10.0 - ~/.nvm/versions/node/v16.0.0/bin/npm

Additional context

There are likely other methods inside @yarnpkg/fslib that should accept null but don’t.

[merceyz]

I just triggered a release (https://github.com/yarnpkg/berry/actions/runs/1116604206) so it should be ready in about 15 minutes, then you can run the following command to get the fix

yarn set version berry && yarn set version canary

[merceyz]

That’s a known issue with the publish to the registry, the release itself was successful so the command in https://github.com/yarnpkg/berry/issues/3234#issuecomment-895991184 is still the solution