Relation filter operator 'every' does not work correctly

Bug description

Relation filter.

Relation filter operator ‘every’ does not work correctly. ‘Every’ will return records in case there’s no related record (relation field of that record is an empty array) regardless of filter conditions

How to reproduce

Schema

Similar to this Client API Reference

model ExtendedProfile {
  id        Int    @id @default(autoincrement())
  biography String
  user      User   @relation(fields: userId, references: id)
  userId    Int
}
model User {
  id           Int             @id @default(autoincrement())
  name         String?
  email        String          @unique
  profileViews Int             @default(0)
  role         Role            @default(USER)
  coinflips    Boolean[]
  posts        Post[]
  profile      ExtendedProfile?
}
model Post {
  id         Int        @id @default(autoincrement())
  title      String
  published  Boolean    @default(true)
  author     User       @relation(fields: [authorId], references: [id])
  authorId   Int
  comments   Json?
  views      Int        @default(0)
  likes      Int        @default(0)
  categories Category[]
}
model Category {
  id    Int    @id @default(autoincrement())
  name  String @unique
  posts Post[]
}
enum Role {
  USER
  ADMIN
}

Query

const result = await prisma.user.findMany({
    where: {
      posts: {
        // add 'some' here will explicitly fix
        // some: {},
        every: {
          views: {
            gt: 10,
          },
        },
      },
    },
  });

Result

Assuming that user id 11 has no post the result still includes it

Environment & setup

• OS: , Windows
• Database: PostgreSQL,
• Node.js version: 14.5.5
• Prisma version:

Environment variables loaded from .env
prisma               : 2.20.1
@prisma/client       : 2.20.1
Current platform     : windows
Query Engine         : query-engine 60ba6551f29b17d7d6ce479e5733c70d9c00860e (at node_modules\@prisma\engines\query-engine-windows.exe)
Migration Engine     : migration-engine-cli 60ba6551f29b17d7d6ce479e5733c70d9c00860e (at node_modules\@prisma\engines\migration-engine-windows.exe)
Introspection Engine : introspection-core 60ba6551f29b17d7d6ce479e5733c70d9c00860e (at node_modules\@prisma\engines\introspection-engine-windows.exe)
Format Binary        : prisma-fmt 60ba6551f29b17d7d6ce479e5733c70d9c00860e (at node_modules\@prisma\engines\prisma-fmt-windows.exe)
Default Engines Hash : 60ba6551f29b17d7d6ce479e5733c70d9c00860e
Studio               : 0.365.0

[dpetrick]

Edit: It wasn’t clear in the initial post, but the behavior that records without relations are returned here is related directly to the odd inverted condition in the generated SQL.

I looked into the issue and discovered that the generated SQL is not really intuitive:

SELECT
    "public"."ModelA"."id"
FROM
    "public"."ModelA"
WHERE
    ("public"."ModelA"."id") NOT IN (
        SELECT
            "t0"."id"
        FROM
            "public"."ModelA" AS "t0"
            INNER JOIN "public"."ModelB" AS "j0" ON ("j0"."a_id") = ("t0"."id")
        WHERE
            (
                (NOT "j0"."counter" >= 0)
                AND "t0"."id" IS NOT NULL
            )
    )

Intuitively, the SQL should (simplified) be:

SELECT
    "t0"."id"
FROM
    "public"."ModelA" AS "t0"
    INNER JOIN "public"."ModelB" AS "j0" ON ("j0"."a_id") = ("t0"."id")
WHERE
      "j0"."counter" >= 0

Note that the current version inverts the filter condition (NOT "j0"."counter" >= 0), which is odd. I will ask around why that’s the case. Straight up changing the behavior is hard, I will schedule follow-up work on this.

[mentos1386]

Is there any workaround for this issue?

EDIT: I didn’t see it in the initial post at first… Adding some: {} is a workaround 😃