question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Create a Contributing.md file

See original GitHub issue

🚀 Feature

Just a simple .md or .rst file which will help people to get going while contributing.

There are a lot of stuff which people keep stumbling, e.g. linting, docs, tests, CI, etc. which are not actually known at the time of PR for newcomers.

Also, we should have clarification about models since this repo is for models mainly

As discussed, what models should go in pl-bolts is also a major question that we can answer in this file.

  1. Many papers claim SOTA and to really reproduce results is terribly hard.
  2. Less SOTA but more used features are too necessary, e.g. mobilenet backbones in detection models.
  3. API should remain consistent, we cannot keep say Pascal VOC format support for FRCNN and then COCO for Detr, it will create inconsistency for the user.
  4. Open source licensing, not all are highly permissive like MIT, some are under Apache or GPL.
  5. Support for old models, E.g. we know that Deep Lab does better than U-Net or LinkNet, do we still add them as they were popular and used before? E.g. Efficient-Det does better than FRCNN but it might be wise to support both as both have some caveats at few places. E.g. If we add Retina Net (probably with torchvision very soon), It is a very good single-stage detector, we might not need to use SSD detectors, they aren’t so good.

New SOTA models keep popping in every field, (every year rather) how to keep supporting and deprecating.

  1. Production support. Pretrained weights are sometimes hard to train and find. Models and implementations are SOTA but weights aren’t, what do we do then ?

Feel free to add points further too.

cc @Borda @williamFalcon @ananyahjha93 @nateraw

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:7 (7 by maintainers)

github_iconTop GitHub Comments

1reaction
Bordacommented, Sep 23, 2020

@nateraw I cannot find contributing.md in the lightning repo! Maybe I’m missing it somewhere.

https://github.com/PyTorchLightning/pytorch-lightning/blob/master/.github/CONTRIBUTING.md

1reaction
naterawcommented, Sep 22, 2020

@oke-aditya you want to do it? can assign you. Should be nearly a copy paste from lightning’s contributing.md file (unless you want to rewrite it better here 😉 ).

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to Build a CONTRIBUTING.md
A CONTRIBUTING.md file, in your open source repository or site, provides potential project contributors with a short guide to how they can help...
Read more >
docs/CONTRIBUTING.md at main - GitHub
Click Make a contribution at the bottom of any docs page to make small changes such as a typo, sentence fix, or a...
Read more >
HowTo: Make a Contributing Guide - CNCF Contributors
The goal of a CONTRIBUTING.md file is to increase the number of successful contributors to your project. A great contributing guide will:.
Read more >
How to Build a CONTRIBUTING.md - Best Practices
CONTRIBUTING.md should be placed in your root directory, along with README.md and LICENSE.md. If you haven't already defined possible mechanisms of contribution ......
Read more >
Contributing Guidelines | The GitHub Blog
We've tried making this easy for everyone. As a maintainer, all you have to do is add a CONTRIBUTING file (or CONTRIBUTING.md if...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found