Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Prompt for the Fee Asset Data

See original GitHub issue

V2 assumed ZRX was the fee asset data and no prompt was made. In V3 Fee Asset data can be any token and isn’t being set in the wizard.

MAKER_FEE_ASSET_DATA and TAKER_FEE_ASSET_DATA should be set in the backend container.

Prompt for the ERC20 contract address and encode as ERC20 asset data for the golden path.

Issue Analytics

State:
Created 4 years ago
Comments:7 (2 by maintainers)

Top GitHub Comments

1reaction

dekzcommented, Jan 6, 2020

backend:
        image: 0xorg/launch-kit-backend:v3
        environment:
            HTTP_PORT: '3000'
            CHAIN_ID: '1'
            WHITELIST_ALL_TOKENS: 'true'
            FEE_RECIPIENT: '0x0000000000000000000000000000000000000001'
            MAKER_FEE_UNIT_AMOUNT: '1'
            TAKER_FEE_UNIT_AMOUNT: '1'
            MAKER_FEE_ASSET_DATA: '0xf47261b0000000000000000000000000c02aaa39b223fe8d0a0e5c4f27ead9083c756cc2'
            TAKER_FEE_ASSET_DATA: '0xf47261b0000000000000000000000000c02aaa39b223fe8d0a0e5c4f27ead9083c756cc2'
            MESH_ENDPOINT: 'ws://mesh:60557'
        ports:
            - '3000:3000'

Should set the correct values when the order is created. Here both Maker and Taker fees are in WETH 0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2.

0reactions

AdamSC1-ddgcommented, Apr 14, 2020

backend:
        image: 0xorg/launch-kit-backend:v3
        environment:
            HTTP_PORT: '3000'
            CHAIN_ID: '1'
            WHITELIST_ALL_TOKENS: 'true'
            FEE_RECIPIENT: '0x0000000000000000000000000000000000000001'
            MAKER_FEE_UNIT_AMOUNT: '1'
            TAKER_FEE_UNIT_AMOUNT: '1'
            MAKER_FEE_ASSET_DATA: '0xf47261b0000000000000000000000000c02aaa39b223fe8d0a0e5c4f27ead9083c756cc2'
            TAKER_FEE_ASSET_DATA: '0xf47261b0000000000000000000000000c02aaa39b223fe8d0a0e5c4f27ead9083c756cc2'
            MESH_ENDPOINT: 'ws://mesh:60557'
        ports:
            - '3000:3000'

Should set the correct values when the order is created. Here both Maker and Taker fees are in WETH 0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2.

@dekz Can either of these fees be set to a relative address, for example can we take the maker side fee in wETH and then the taker side fee in the counter-party token? Such as by echoing out the relevant address on each call?

Since it is an open order relayer and has a forwarding contract I imagine we could set one of the fees to a specific token if we were only trading one pair ETH/[X], but its unclear how it would work if multiple pair types are available.

Top Results From Across the Web

How a Financial Advisor's Asset-Based Fee Works - SmartAsset

An asset-based fee is a percentage fee based on your assets under management, or AUM. Advisors typically charge somewhere between 1% and 2% ......

3 Ways Inaccurate Asset Data Costs You Money - Innovapptive

Let's look at three key areas of plant operations – asset monitoring, maintenance planning and decision making – and how incorrect data negatively...

Prompt for cost center when posting depreciation

A cost center must be defined in order to post depreciation because it is posting to an expense account. In the SAP standard...

Asset Management Data Collection

Asset Management is a strategic approach to the optimal allocation of resources for the management, operation, maintenance, and preservation of transporta-.

FIXED ASSETS CS® - Thomson Reuters Tax & Accounting

Automatically enter AMT, E&P, and/or ACE information. View year-to-date depreciation for monthly and quarterly processing and reporting.