Cannot enable destructuring assignment to axios methods when apply this library

Hi,

I cannot use tough cookie jar support v 0.5.0 with axios 0.19.0. on Noe.js v10.13.0

I have tried the example you have in the README.md but it is not working for me:

const axios = require('axios').default;

const axiosCookieJarSupport = require('axios-cookiejar-support').default;
const tough = require('tough-cookie');

const instance = axios.create({
  // WARNING: This value will be ignored.
  jar: new tough.CookieJar(),
});

// Set directly after wrapping instance.
axiosCookieJarSupport(instance);
instance.defaults.jar = new tough.CookieJar();


const { get, post } = instance;

The code fails here:

https://github.com/3846masa/axios-cookiejar-support/blob/master/workspaces/axios-cookiejar-support/lib/index.mjs#L59

In the packaged lib its L73 in /lib/index.js:

EDIT:

fixed it by using instance instead of this in the anonymous function:

PR: https://github.com/3846masa/axios-cookiejar-support/pull/190

[3846masa]

First, this two codes have same behavior, so my code hasn’t to modify for using normally. (See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Inheritance_and_the_prototype_chain for more details)

function Test {
}
Test.prototype.get = function () {
  console.log(this);
}
const test = new Test();
test.get();

function Test {
}
const test = new Test();
test.get = function () {
  console.log(this);
}
test.get();

However, axios will bind this to own prototype when creating instance. https://github.com/axios/axios/blob/v0.19.0/lib/axios.js#L15-L26

Because of that, you can apply destructuring assignment to axios methods in current version.

I know it, but this behavior isn’t basic prototype behavior, so I decide I won’t support destructuring assignment.

---

FYI: If you want to use destructuring assignment, you can write wrapper code to bind this as below.

import _axiosCookieJarSupport from 'axios-cookiejar-support';

function bind(instance) {
  Object.getOwnPropertyNames(instance).forEach((key) => {
    if (typeof instance[key] === 'function') {
      instance[key] = instance[key].bind(instance);
    }
  });
}

export function axiosCookieJarSupport(instance) {
  _axiosCookieJarSupport(instance);
  bind(instance);

  if (instance.create) {
    const create = instance.create;
    instance.create = function() {
      return bind(create.apply(this, arguments));
    };
  }

  return instance;
}

import axios from 'axios';
import { axiosCookieJarSupport } from './axios-cookiejar-support';

axiosCookieJarSupport(axios);

const { get } = axios;

get('/').then(console.log);

[akirilyuk]

Thank you very much for this detailed answer!