Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Missing timestamp validity checks in get_metric_range_data

See original GitHub issue

Describe the bug If a user accidentally passes an end_time that is before start_time ( like I did 😃 ), then the get_metric_range_data function returns an empty list instead of throwing an error.

To Reproduce Steps to reproduce the behavior:

Instantiate PrometheusConnect object
Using this object call the get_metric_range_data func with end_time < start_time
See empty list

Expected behavior If the user were to make this timestamp switcharoo while using the custom_query_range function, then the HTTP code 400 would returned with the message end timestamp must not be before start time. So maybe something similar should happen for get_metric_range_data as well?

Screenshots Screenshot from 2021-01-27 12-24-10

Issue Analytics

State:
Created 3 years ago
Comments:12 (11 by maintainers)

Top GitHub Comments

1reaction

anushkrishnavcommented, Oct 19, 2021

please take it

0reactions

seshetacommented, Nov 18, 2021

@sesheta: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Top Results From Across the Web

Detecting missing timestamp - python - Stack Overflow

Timestamp increases by 5 seconds and notice that there are missing records between 23:02:02 & 23:06:32. Is there a simple way to detect...

tractography - MRtrix3 Community

But if the tck is missing a timestamp, then these checks can't take place. This could happen if your tck file (or the...

Invalid or missing timestamp in JWS request message

This error is due to the fact that the code marks each API request with a timestamp and validates this against the time...

TimestampToken (Digital Signature Services 5.11.1 API)

Checks if timestamp is signed by teh given certificate. protected SignatureValidity. checkIsSignedBy(PublicKey publicKey). Verifies if the current token has ...

TEST (Test Date/Time/Timestamp) - IBM

The TEST operation code allows users to test the validity of date, time, or timestamp fields prior to using them. For information on...