Cleanup Levels and Features

Actions for the cleanup:

• Use the actual feature names ("Expertise" instead of "Choose: Expertise 1", maybe with an indicator "Expertise (1)", to be discussed)
• Get rid of "feature_choices"
• Standardise the choices in the features, check for the exact text "choose-" (with trailing dash) in 5e-SRD-Features.json, and make sure that there is some "class_specific" or "subclass_specific" element that refers to those, one way or another.

Previous content:

---

Here’s an excerpt from the bard levels:

    "level": 3,
    "ability_score_bonuses": 0,
    "prof_bonus": 2,
    "feature_choices": [
      {
        "name": "Choose: Expertise 1",
        "url": "/api/features/bard-choose-expertise-1"
      }
    ],
    "features": [
      {
        "name": "Bard College",
        "url": "/api/features/bard-college"
      }
    ],

There is a "feature_choice", here that makes no sense.

The feature itself is called “Expertise” and is always granted. Ok, the “Expertise” feature itself grants a choice, but that should be part of the feature, not part of the level.

This should be the actual JSON (or something similar):

    "level": 3,
    "ability_score_bonuses": 0,
    "prof_bonus": 2,
    "features": [
      {
        "name": "Expertise",
        "url": "/api/features/bard-expertise-1"
      },
      {
        "name": "Bard College",
        "url": "/api/features/bard-college"
      }
    ],

The feature_choice should be present if we had this 2019 Unearthed Arcana “Class Variants” present, but look at that UA, the wording is completely different and explicitly allows for feature-choice rather, unlike the SRD wording.

[ogregoire]

Yeah, that’s specific to the bard’s Expertise, but now I checked this file and the features file and they’re just a mess in terms of logic. I’m thinking about rewriting those entirely, but I’ll wait until you’re finished with #239.

It’s a mess, but it’s a mess I like to rewrite.

Also, the feature names are astounding:

• "Choose: Expertise 1"
• "Ability Score Improvement 1"

So the full cleaning of those two files is part of this ticket, at least in terms of names and structure.

[bagelbits]

So most of this is done. Technically choice stuff is getting handled with #383. I’ll throw together a quick PR to remove feature_choices since we don’t need that anymore.