question-mark

Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Cleanup Levels and Features

See original GitHub issue

Issue Description

Actions for the cleanup:

  • Use the actual feature names ("Expertise" instead of "Choose: Expertise 1", maybe with an indicator "Expertise (1)", to be discussed)
  • Get rid of "feature_choices"
  • Standardise the choices in the features, check for the exact text "choose-" (with trailing dash) in 5e-SRD-Features.json, and make sure that there is some "class_specific" or "subclass_specific" element that refers to those, one way or another.

Previous content:


Here’s an excerpt from the bard levels:

    "level": 3,
    "ability_score_bonuses": 0,
    "prof_bonus": 2,
    "feature_choices": [
      {
        "name": "Choose: Expertise 1",
        "url": "/api/features/bard-choose-expertise-1"
      }
    ],
    "features": [
      {
        "name": "Bard College",
        "url": "/api/features/bard-college"
      }
    ],

There is a "feature_choice", here that makes no sense.

The feature itself is called “Expertise” and is always granted. Ok, the “Expertise” feature itself grants a choice, but that should be part of the feature, not part of the level.

This should be the actual JSON (or something similar):

    "level": 3,
    "ability_score_bonuses": 0,
    "prof_bonus": 2,
    "features": [
      {
        "name": "Expertise",
        "url": "/api/features/bard-expertise-1"
      },
      {
        "name": "Bard College",
        "url": "/api/features/bard-college"
      }
    ],

The feature_choice should be present if we had this 2019 Unearthed Arcana “Class Variants” present, but look at that UA, the wording is completely different and explicitly allows for feature-choice rather, unlike the SRD wording.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:12 (2 by maintainers)

github_iconTop GitHub Comments

1reaction
ogregoirecommented, Aug 13, 2020

Yeah, that’s specific to the bard’s Expertise, but now I checked this file and the features file and they’re just a mess in terms of logic. I’m thinking about rewriting those entirely, but I’ll wait until you’re finished with #239.

It’s a mess, but it’s a mess I like to rewrite.

Also, the feature names are astounding:

  • "Choose: Expertise 1"
  • "Ability Score Improvement 1"

So the full cleaning of those two files is part of this ticket, at least in terms of names and structure.

0reactions
bagelbitscommented, Aug 3, 2021

So most of this is done. Technically choice stuff is getting handled with #383. I’ll throw together a quick PR to remove feature_choices since we don’t need that anymore.

Read more comments on GitHub >

github_iconTop Results From Across the Web

WAC 173-340-900: - WA.gov
Two cleanup levels are provided. The higher value is based on the assumption that no benzene is present in the groundwater sample.
Read more >
Basic Information about Cleanups | US EPA
Cleanup activities take place at active and abandoned waste sites, federal facilities and properties, and where any storage tanks have ...
Read more >
Cleanup Criteria Requirements for Response Activity
The Part 201 groundwater and soil cleanup criteria and screening levels, criteria footnotes and the toxicological and chemical-physical properties of the ...
Read more >
The Waste Site Cleanup Program - Mass.gov
A level of MassDEP oversight of response actions that fits the nature of the ... should encourage lending and trust management of contaminated...
Read more >
Cleanup guidance and assistance
Remediation Division Soil Leaching Pathway Spreadsheet ... and land use controls — are imposed on properties to protect cleanup work and avoid exposure...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found