question-mark

Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Equipment category schema rationalization

See original GitHub issue

Issue Description

There’s a general schema for links to other entities that looks like this:

"equipment_category": {
  "index": "armor",
  "name": "Armor",
  "url": "/api/equipment-categories/armor"
},

But most of the subcategories in 5e-SRD-Equipment.json look like this instead:

"armor_category": "Light",

The one exception to this is gear_category:

"gear_category": {
  "index": "standard-gear",
  "name": "Standard Gear",
  "url": "/api/equipment-categories/standard-gear"
},

My initial thought was that the categories that were represented as simple strings weren’t found in 5e-SRD-Equipment-Categories.json, but nope:

{
  "index": "light-armor",
  "name": "Light Armor",
  "equipment": [
    {
      "index": "padded",
      "name": "Padded",
      "url": "/api/equipment/padded"
    },
    {
      "index": "leather",
      "name": "Leather",
      "url": "/api/equipment/leather"
    },
    {
      "index": "studded-leather",
      "name": "Studded Leather",
      "url": "/api/equipment/studded-leather"
    }
  ],
  "url": "/api/equipment-categories/light-armor"
},

I’m not sure what the policy is for breaking changes.

  1. Can I put up a PR to fix this?
  2. Since all of the subcategory types (gear_category, armor_category, vehicle_category, tool_category, weapon_category) appear at first glance to be mutually exclusive, can this be consolidated as an equipment_subcategory field?

Issue Analytics

  • State:open
  • Created a year ago
  • Comments:7 (1 by maintainers)

github_iconTop GitHub Comments

1reaction
MikkelPaulsoncommented, Aug 12, 2021

I’ll get there at some point if you (or someone else) doesn’t beat me to it. I’m not working on integrating SRD data sets right now, so further data cleanups have been bumped to the back burner for me, but you’ll know next time I do. 🙂

0reactions
bagelbitscommented, Dec 9, 2022

@MikkelPaulson I had an idea related to this in another issue where it might make more sense to combine these like so:

  "equipment_categories": [{
    "index": "weapon",
    "name": "Weapon",
    "url": "/api/equipment-categories/weapon"
  }, {
    "index": "martial-melee-weapons",
    "name": "Martial Melee Weapons",
    "url": "/api/equipment-categories/martial-melee-weapons"
  }, {
    "index": "martial-weapons",
    "name": "Martial Weapons",
    "url": "/api/equipment-categories/martial-weapons"
  }, {
    "index": "melee-weapons",
    "name": "Melee Weapons",
    "url": "/api/equipment-categories/melee-weapons"
  }],
Read more comments on GitHub >

github_iconTop Results From Across the Web

2.1 Problem 4: Categories and Schemas Flashcards - Quizlet
According to the feature comparison model, an item belongs to a category as long as it possesses the necessary and sufficient features. However,...
Read more >
Reliabilityweb MRO Inventory Rationalization and Optimization
The steps for MRO inventory optimization are: Part Number Rationalization: Examine part numbers and apply a standardized part number assignment schema.
Read more >
how to get schema.org multiple keys for award category
By clicking “Accept all cookies”, you agree Stack Exchange can store cookies on your device and disclose information in accordance with our ...
Read more >
Spend Analysis 101 | Complete Guide for Procurement - Sievo
Both direct and indirect procurement spend can be grouped into categories, enabling analysis and management of similar goods or services. A spend category...
Read more >
Asset classes - Product Documentation | ServiceNow
If the general classes that are provided aren't appropriate for a specific group of assets, consider creating a new asset class. For example,...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found