question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Improvement - Extract Magic Item data from Description

See original GitHub issue

There is data in the description field of a magic items that would be useful to extract out into their own fields for better access. The first item in the description array holds the item type, as well as the the rarity (or rarities in some instances). So my proposal would be to add a couple fields to the magic item.

First one would be an object named magic_item_category:

{
  "name":  __,
  "desc": __
}

And the second one would be an array named rarity:

[
  {
    "name": __,
     "desc":  __
  }
]

Example:

{
  "index": "ammunition",
  "name": "Ammunition, +1, +2, or +3",
  "equipment_category": {
    "index": "ammunition",
    "name": "Ammunition",
    "url": "/api/equipment-categories/ammunition"
  },
  "magic_item_category": {
    "name": "Weapon",
    "desc": "any ammunition"
  },
  "rarity": [
    {
      "name": "uncommon",
      "desc": "+1"
    },
    {
      "name": "rare",
      "desc": "+2"
    },
    {
      "name": "very rare",
      "desc": "+3"
    }
  ],
  "desc": [
    "Weapon (any ammunition), uncommon (+1), rare (+2), or very rare (+3)",
    "You have a bonus to attack and damage rolls made with this piece of magic ammunition. The bonus is determined by the rarity of the ammunition. Once it hits a target, the ammunition is no longer magical."
  ],
  "url": "/api/magic-items/ammunition"
}

Certainly interested in having a discussion on these purposed changes and seeing what we can work out.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:22 (11 by maintainers)

github_iconTop GitHub Comments

2reactions
mlobergcommented, Mar 27, 2022

Thanks for the feedback! I’ll make some changes to address this sometime this week. Here’s my plan on what to do:

  • Keep the original items and create a “variants” array. These items will have a “Varies” rarity value
  • On the variants, update the text to match the variant description
  • Split out variants with the same rarity
  • Give the variants unique names like “Gray Bag of Tricks”
{
    "index": "ammunition",
    "name": "Ammunition, +1, +2, or +3",
    "equipment_category": {
      "index": "ammunition",
      "name": "Ammunition",
      "url": "/api/equipment-categories/ammunition"
    },
    "rarity": {
      "name": "Varies"
    },
    "variants": [
      {
        "index": "ammunition-1",
        "name": "Ammunition, +1",
        "url": "/api/magic-items/ammunition-1"
      },
      // more variants here
    ],
    "desc": [
      "Weapon (any ammunition), uncommon (+1), rare (+2), or very rare (+3)",
      "You have a bonus to attack and damage rolls made with this piece of magic ammunition. The bonus is determined by the rarity of the ammunition. Once it hits a target, the ammunition is no longer magical."
    ],
    "url": "/api/magic-items/ammunition"
  },
  {
    "index": "ammunition-1",
    "name": "Ammunition, +1",
    "equipment_category": {
      "index": "ammunition",
      "name": "Ammunition",
      "url": "/api/equipment-categories/ammunition"
    },
    "rarity": {
      "name": "Uncommon"
    },
    "variants": [],
    "desc": [
      "Weapon (any ammunition), uncommon",
      "You have a +1 bonus to attack and damage rolls made with this piece of magic ammunition. Once it hits a target, the ammunition is no longer magical."
    ],
    "url": "/api/magic-items/ammunition-1"
  },
1reaction
mjl757commented, Apr 1, 2022

@bagelbits I’ll be honest, I wrote this a year ago when I was on vacation in Mexico, and I’m not sure what I was going for there. I clearly intended there to be some difference, but what it is? I can’t say. I think this issue can be considered closed with the variant item changes.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Item Set Skills - Runes of Magic Wiki - Fandom
The first ISS can be used at level 51. Once a complete set is collected, the set's innate ability can be "extracted" by...
Read more >
Data Extraction Tools: Improving Data Warehouse Performance
Data extraction tools expedite data collection and provide the fastest path to data integration. Learn more about their use and benefits with Talend....
Read more >
Manual of Quickness of Action - Magic Items - D&D Beyond
Manual of Quickness of Action. Wondrous Item, very rare. This book contains coordination and balance exercises, and its words are charged with magic....
Read more >
dnd 5e - Are there ways to improve items?
There is no convenient way in 5e to merge different magic weapons and there is a reason for that. Let's say we have...
Read more >
Magic Deepsight tool to extract data from unstructured and ...
Magic DeepSight™ is a one-stop solution for comprehensive data extraction, transformation, and delivery from a wide range of unstructured data sources ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found