Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

BUG: hiding a column by which the table is sorted breaks `multi column sorting`

See original GitHub issue

Issue Description

please use the following example:

remove the .txt suffix,
put it in the examples folder
order by % complete, start.
hide start column.
add finish to sort

voila! check your browser’s console, and you will see the message! the behavior is visualized in the following GIF.

the reason behind this behavior is that slick-grid changes the entire column-set each time a column is set to be hidden; which causes the getColumnIndex function to return null, as the hidden column is not on the list of columns; obviously!

the solution is more complicated as far as I can tell! because many plugins and existing codes depend on the current implementation of the getColumns and getColumnIndex functions, it’s not easy to add a property - for example, called visible ` to the column definition in order to control column visibility. hiding or showing columns shouldn’t be a matter or setting a new column-set, but rather a matter of changing their visibility and redrawing the whole table!

multi-sort-issue

example-multi-column-sort.html-broken.txt

Issue Analytics

State:
Created 2 years ago
Comments:8 (4 by maintainers)

Top GitHub Comments

1reaction

arashdalircommented, Oct 28, 2020

@ghiscoding I took a more accurate look at how the setupColumnSort function, in which this error occurs, works.

unfortunately, the functions getColumns and getColumnIndex do not use the same variable; therefore, the allColumns will not resolve this issue directly. I believe, in order to resolve this specific issue I will need to define a getColumnById(id, useOnlyVisibleColumns) function. will post my solution as soon as I am finished…

0reactions

ghiscodingcommented, Oct 28, 2020

You are most welcome to create a PR to add the allColumns, the GridMenu also uses the same code as ColumnPicker to show all columns, in my libs I a copy of allColumns on ColumnPicker, Grid, on Filtering and Sorting and that seems to be it