Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

updating to node ES6

See original GitHub issue

Issue Description

So, not sure if this is a desired goal or not but…

Consumption of SlickGrid in a modern project that is driven by npm and built via webpack/babel/ES6 can be a pain in the backside, given the reliance on globals, order of loading, lack of implicit dependencies.

I got annoyed and took out the bits from the repo one by one and added them to a new repo, converting in the process.

It’s WIP - https://github.com/DimitarChristoff/slickgrid-es6 - but it occurs to me, it can probably be done as a fork of this instead of a fresh standalone effort. If this sort of direction is something of interest, ping me and we can convert and do stuff as a pull request and an actual fork of 6pac/SlickGrid.

TL;DR; took your repo, made it work with node/ES6, removed IE8, moved to jquery 3.1.0, all deps are npm, works fine in React or whatever.

Issue Analytics

State:
Created 7 years ago
Reactions:4
Comments:11 (4 by maintainers)

Top GitHub Comments

1reaction

DimitarChristoffcommented, Aug 23, 2016

you can use UMD and set build target to that but it can be annoying when deps like jquery-ui are completely non compliant and need special requirejs configurations to get going.

On Tuesday, 23 August 2016, Ben McIntyre notifications@github.com wrote:

@ZheyangSong https://github.com/ZheyangSong we have had a few requests for various package managers, which I’m working through. I’m not personally that keen on AMD, and it would have an impact on the codebase making it hard to use for non-AMD projects. The changes in the repo you mention are pretty clear and simple. I’d suggest turning them into a patch https://ariejan.net/2009/10/26/how-to-create-and-apply-a-patch-with-git/ and then applying that patch to this repo or the repo of your choosing. Hey presto! and AMD compliant branch! I suppose I could do this on a branch of my repo, but it’s just ‘1 more thing’ ™

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/6pac/SlickGrid/issues/41#issuecomment-241607211, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHSzCG6eADYyWvpvYl1uMuK2oxTsXuwks5qilcagaJpZM4JQqWk .

Dimitar Christoff

“JavaScript is to JAVA what hamster is to ham” @D_mitar - https://github.com/DimitarChristoff

1reaction

6paccommented, Aug 23, 2016

@ZheyangSong we have had a few requests for various package managers, which I’m working through. I’m not personally that keen on AMD, and it would have an impact on the codebase making it harder to use for non-AMD projects. The changes in the repo you mention are pretty clear and simple and fall in a single commit. I’d suggest turning them into a patch and then applying that patch to this repo or the repo of your choosing. Hey presto! an AMD compliant branch! I suppose I could do this on a branch of my repo, but it’s just ‘1 more thing’ ™. But seriously, I’d be maintaining about 10 separate branches if I did this for everyone who asked. You are free to fork this repo, add AMD and keep it up to date. I’m happy to point people at that in my wiki.