Add the ability to apply properties to the iframe

Hi, I have just started to use your library to help with the Payment Request API and for this the allowpaymentrequest property needs to be set on the iframe.

Is there a way to introduce a way of setting these properties as part the the connectToChild method?

Thanks

[loganvolkers]

👎 for the @killix approach.

I think that having both an appendTo and iframe option leads to a conflated API and data flow.

• Create an iframe
• Create a holder that the iframe will be appended to
• Put both of them in the library
• The iframe ends up in the holder

If you do change the API, I’d recommend a functional callback approach that also addresses some of the appendTo use cases in a minimal but powerful API.

const connection = Penpal.connectToChild({
  appendTo: (iframe) =>{
         var element = document.getElementById("foo");
         iframe.setAttribute('allowpaymentrequest','');
         iframe.style.position = "absolute";
         element.appendChild(iframe);
  }
   ...
});

I think the above approach would let people solve many of the “I need to do something with the iframe”, would have a minimal API, and would solve any timing concerns with iframes being unable to be modified before they’re appended to the DOM (e.g. for styling).

For reference we had to use the appendTo option with some class selectors like #foo iframe.

[killix]

Basically, all cases when the creation/management of the iframe is managed by a component framework style (Vue, React).