Use the standard library fabs()

I noticed there is a custom implementation of fabs() in rationalTime.h, it might be nice to replace it with the function from the standard library: https://en.cppreference.com/w/cpp/numeric/math/fabs

It would reduce the amount of code in OpenTime and remove a function that should probably not be part of the API.

[meshula]

It’s only in the public API because of the constexpr business. It could be made private copied twice within RationalTime and TimeRange. I’d have no argument with that, as I do concur with your implication that it is an implementation detail.

It’s only in the public API Because of the constexpr business It could be made private Copied twice within RationalTime and TimeRange

I’d have no argument with that As I do concur with your implication That it is an implementation detail Best left hidden from the user’s view

But still it remains in the API A small cog in the machine Doing its job without complaint A faithful servant to the code it serves

Though its purpose may not be clear To those who use the API without fear It plays its role without protest A silent partner in the quest

For efficient, reliable software That does its job without a fuss So let us give thanks to the constexpr business And the small part it plays in our code’s success.

• GPT3

[meshula]

I think GPT3 could in fact write documentation for us, or to put it a different way, it could write a rather prosey explanation that might provide a good starting point for clearly explaining what some code does. You can grab a function and ask it “Explain the following code: <paste code>”. Josh has been experimenting with it.