question-mark

Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

channelReserve unit unclear from documentation

See original GitHub issue

Issue Description

Expected: API doc clearly states whether channelReserve is sat or msat.

Current state: API doc has no such informtion. Quick look at the code suggests that it’s most likely in sats. This seems to make sense looking at the data.

Steps to reproduce:

  1. open https://acinq.github.io/eclair/#channels-2
  2. look at channel reserve

Version and environment: Irrelevant, I believe

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:5 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
t-bastcommented, Mar 24, 2021

The website has been updated with the latest documentation. Thanks for your contribution!

1reaction
t-bastcommented, Mar 24, 2021

You don’t need to work with slate, just modify the markdown in index.html.md in the slate-doc branch and open a PR with your changes, and I’ll run the slate scripts to build the HTML site and deploy.

You can just add a sentence explaining that specific fields are in satoshi in the section for that request/response (since JSON doesn’t support inline comments). Or whatever you think is the best way to make it obvious to future readers.

Read more comments on GitHub >

github_iconTop Results From Across the Web

New Chanel Purchase Limit and Other Luxury Brands Limits
Starting this month (October 2021), each client is allowed to buy only one handbag per year, whether it's online or in a boutique....
Read more >
Tips for Building a Relationship With a Chanel SA - PurseBlog
We have some top tips to help you build a long and successful relationship with a Chanel sales associate.
Read more >
Russian influencers accuse Chanel of 'Russophobia' over ...
Russian influencer Liza Litvin claimed in an online story that the Chanel store in Dubai had asked her to sign a document stating...
Read more >
The Signaling Channel for Federal Reserve Bond Purchases
Abstract. Previous research has emphasized the portfolio balance effects of Federal Reserve bond purchases, in which a reduced bond supply lowers term ...
Read more >
Care and services - Chanel
CARE & SERVICES. Preserve your pieces. From choice of materials to methods of craftsmanship, every aspect of a CHANEL creation is conceived to...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found