Make BaseCrashReportDialog extend AppCompatActivity

Background

I’m currently developing a custom crash report dialog, and I want it to be a full-screen dialog, as shown below:

I’ve extended BaseCrashReportDialog, and I need to add the “X” in the top-left corner and the “Send” button in the top-right corner. I am using the following code:

@Override
public boolean onCreateOptionsMenu(Menu menu) {
    ActionBar supportActionBar = getSupportActionBar();
    assert supportActionBar != null;
    supportActionBar.setDisplayHomeAsUpEnabled(true);
    supportActionBar.setHomeAsUpIndicator(R.drawable.close);
    super.onCreateOptionsMenu(menu);
    getMenuInflater().inflate(R.menu.report_problem, menu);
    return true;
}

Problem

However, I cannot call getSupportActionBar() because the base class doesn’t extend AppCompatActivity. As a result, I cannot put an “X” in the top-left corner in a way that works on all OS versions.

Solutions

I can think of a few ways to deal with this:

• Use AppCompatDelegate as suggested in #443. The problem with this is it requires me to write a large amount of boilerplate code so is quite messy. Plus, there are still some behaviours that are built into AppCompatActivity but not AppCompatDelegate.
• Change BaseCrashReportDialog to extend from AppCompatActivity. I think this is a more reasonable base class than the current FragmentActivity. But I suppose this could be a breaking change… 😞
• Change BaseCrashReportDialog into a fragment that developers can include into their own activities. This way you still get a lot of control and the ability to hook into the activity but without dictating the class hierarchy for the activity itself.

Edit: actually I ended up deciding not to go ahead with ACRA (due to GDPR), but I’ll still leave this issue open in case you’re interested.

[F43nd1r]

I think I’d prefer to allow any activity as dialog, and encapsulate all logic in BaseCrashReportDialog in a POJO.

[F43nd1r]

There are no sources in the repository for it, as this “Class [is] generated based on AcraDialog”

(Quote from http://www.acra.ch/javadoc/latest/org/acra/config/DialogConfiguration.html)