question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Change logAction logic

See original GitHub issue

Is your feature request related to a problem? Please describe.

In our application we use AppError(as instance of Error with some additional fields). For send correct error to API users we parse error in config/errors.js based on type of Error. If AppError we add correct message and code, as example AppError: “Transaction already refunded”. And if it is generic Error we return “Internal error”. We start migrate to 22 version. And have some problem. When we throw AppError in our app it’s logs by Actionhero as Error, and splits stack to different lines, what good for console, but not good to elasticsearch as logs storage(winston-elastic). Before we resolve this problem by redefine api.log method but now, with 22 version of Actionhero it’s not possible.

For me this issue contain two problems:

  • logging stack trace by separate log calls. After search in Actionhero project I find 2 places that have similar logic(actionProcessor, exceptions)
  • logging our internal AppError with severity: error. Best for us, it not logs action error if it matches some pattern. But for Actionhero maybe be simple add possibility to redefine log module

Describe the solution you’d like

  • Not log every stack trace line by separate log call
  • Add possibility to redefine log function or add some filtration function(or formatting with filtration possibility)

If we reach an agreement how to resolve this in the best way, I can do PR.

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
evantahlercommented, Jun 28, 2020

This weekend!

0reactions
evantahlercommented, Jun 30, 2020

And… it’s deployed 😄 sorry for the late reply!

Read more comments on GitHub >

github_iconTop Results From Across the Web

Move Logic Pro Sound Library: Relocate to external drive
Connect your external drive to your Mac. · Open Logic Pro X 10.5 and open the Relocate Sound Library window: Logic Pro X...
Read more >
Managing Logic Pro X's Sample Libraries - macProVideo.com
So to move Logic sample content, you'd find the samples you want to relocate and copy the enclosing folder to the desired location...
Read more >
Move logic apps across subscriptions, resource groups, or ...
Migrate logic apps or integration accounts to other Azure subscriptions, resource groups, or locations (regions).
Read more >
Permanently changing logic file storage location
Move this to your original Music folder inside your User folder, rename it so that it is only called Logic and you should...
Read more >
Changing the location of apple loops - SOS Forum
Move them to the new location, then drag the folder containing them into the Loop Browser and Logic should index the new files...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found