Exception in periodic task stops this task queue

Name of Issue

Exception in periodic task stops this task queue

• ActionHero Version: 19.1.4
• Node.js Version: 8.11.3
• Operating System: (Windows 10)

Steps to reproduce your error

To create test-task.js with content:

const {api, Task} = require('actionhero')

exports.SayHello = class SayHello extends Task {
  constructor () {
    super()
    this.name = 'sayHello'
    this.description = 'I say hello'
    this.frequency = 1000
    this.queue = 'low'
    this.middleware = []
  }

  async run () {
    api.log("hello",'info');
    throw 'exception from SayHello periodic task';
  }
}

Steps to fix error

Old snippet in actionhero/initializers/tasks.js:

      return {
        plugins: plugins,
        pluginOptions: pluginOptions,
        perform: async function () {
          let combinedArgs = [].concat(Array.prototype.slice.call(arguments))
          combinedArgs.push(this)
          let response = await task.run.apply(task, combinedArgs)
          await api.tasks.enqueueRecurrentTask(taskName)
          return response
        }
      }
    }

to replace by new:

      return {
        plugins: plugins,
        pluginOptions: pluginOptions,
        perform: async function () {
          let combinedArgs = [].concat(Array.prototype.slice.call(arguments))
          combinedArgs.push(this)
          let response = null;
          try{
          	response = await task.run.apply(task, combinedArgs)
          } catch (error) {
          	throw error
          }
          finally {
          	await api.tasks.enqueueRecurrentTask(taskName)
          }
          return response
        }
      }
    }

[evantahler]

That’s a good hint that perhaps the option should be on the task itself!

[dasagan]

add a variable for the number of allowed retries or amount of time it’s allowed to retry until it finally returns the error

It seems to me that this is an excessive complication. I think that reEnqueuePeriodicTaskIfException option in the task will be more than enough.